Re: [1/5] d3d9: Use the correct AddRef and Release Macros

[Henri Verbeet]

I don't think this patch makes sense.

[1/5] d3d9: Use the correct AddRef and Release Macros

[Stefan Dösinger]

> I don't think this patch makes sense.

Well, it doesn't do much - IUnknown_AddRef is litterally the same as
IDirect3DDevice9Ex_AddRef(or at least it can be). But I think if we have at
least name-specialized macros for each interface we should use the one that
matches the object we have

Or am I missing something?

[1/5] d3d9: Use the correct AddRef and Release Macros

[Henri Verbeet]

2008/11/3 Stefan Dösinger :
> > I don't think this patch makes sense.
>
> Well, it doesn't do much - IUnknown_AddRef is litterally the same as
> IDirect3DDevice9Ex_AddRef(or at least it can be).

Yes, which is why I don't think the patch makes sense.
> But I think if we have at
> least name-specialized macros for each interface we should use the one that
> matches the object we have

No.

[1/5] d3d9: Use the correct AddRef and Release Macros

[Stefan Dösinger]

> > But I think if we have at
> > least name-specialized macros for each interface we should use the
>
> one that
> > matches the object we have
>
> No.

Why not?