Error in ntdll/module.c?

[Christian Iversen]

(Please CC me, I'm not on the list)

According to:

http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Execut...

The parameter order for LdrGetProcedureAddress is (Handle, Function, 
Ordinal, Address)

The file dlls/ntdll/module.c has the order as (Handle, Ordinal, 
Function, Address)

This of course works well because kernel32.dll is the only caller (and 
it indeed uses, if not the correct, then at least the same order).

I haven't attached a patch, because I'm not actually sure which version 
is right. Anyone?

[Uwe Bonnes]

> > > > > "Christian" == Christian Iversen  writes:

Christian> (Please CC me, I'm not on the list)

Christian> According to:

Christian> http://undocumented.ntinternals.net/UserMode/Undocumented%20Functions/Execut...

Christian> The parameter order for LdrGetProcedureAddress is (Handle,
    Christian> Function, Ordinal, Address)

Christian> The file dlls/ntdll/module.c has the order as (Handle,
    Christian> Ordinal, Function, Address)

Christian> This of course works well because kernel32.dll is the only
    Christian> caller (and it indeed uses, if not the correct, then at least
    Christian> the same order).

Christian> I haven't attached a patch, because I'm not actually sure
    Christian> which version is right. Anyone?

Write a test for our test suite and run the test on wine and a windows
machine. Send at least the test.

Bye