[PATCH] shell32: Fix return value for CreateWindowExW.

[Andrey Gusev]

Signed-off-by: Andrey Gusev 
---
 dlls/shell32/control.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c
index b3931544e4..72b213261d 100644
--- a/dlls/shell32/control.c
+++ b/dlls/shell32/control.c
@@ -634,12 +634,13 @@ static void    Control_DoInterface(CPanel* panel, HWND hWnd, HINSTANCE hInst)

if (!RegisterClassExW(&wc)) return;

-    CreateWindowExW(0, wc.lpszClassName, appName,
-		    WS_OVERLAPPEDWINDOW | WS_VISIBLE,
-		    CW_USEDEFAULT, CW_USEDEFAULT,
-		    CW_USEDEFAULT, CW_USEDEFAULT,
-		    hWnd, NULL, hInst, panel);
-    if (!panel->hWnd) return;
+    panel->hWnd = CreateWindowExW(0, wc.lpszClassName, appName,
+		                  WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+		                  CW_USEDEFAULT, CW_USEDEFAULT,
+		                  CW_USEDEFAULT, CW_USEDEFAULT,
+		                  hWnd, NULL, hInst, panel);
+    if (!panel->hWnd)
+        return FALSE;

while (GetMessageW(&msg, panel->hWnd, 0, 0)) {
         TranslateMessage(&msg);

[Nikolay Sivov]

On 01/04/2018 01:20 PM, Andrey Gusev wrote:
> Signed-off-by: Andrey Gusev
>
> dlls/shell32/control.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/dlls/shell32/control.c b/dlls/shell32/control.c
> index b3931544e4..72b213261d 100644
> --- a/dlls/shell32/control.c
> +++ b/dlls/shell32/control.c
> @@ -634,12 +634,13 @@ static void    Control_DoInterface(CPanel* panel, HWND hWnd, HINSTANCE hInst)
>   if (!RegisterClassExW(&wc)) return;
>
> - CreateWindowExW(0, wc.lpszClassName, appName,
> -
>     WS_OVERLAPPEDWINDOW | WS_VISIBLE,
> -
>     CW_USEDEFAULT, CW_USEDEFAULT,
> -
>     CW_USEDEFAULT, CW_USEDEFAULT,
> -
>     hWnd, NULL, hInst, panel);
> - if (!panel->hWnd) return;
> -
>
> panel->hWnd = CreateWindowExW(0, wc.lpszClassName, appName,
> -
>                   WS_OVERLAPPEDWINDOW | WS_VISIBLE,
> -
>                   CW_USEDEFAULT, CW_USEDEFAULT,
> -
>                   CW_USEDEFAULT, CW_USEDEFAULT,
> -
>                   hWnd, NULL, hInst, panel);
> -
>
> if (!panel->hWnd)
> -
>    return FALSE;
>
> while (GetMessageW(&msg, panel->hWnd, 0, 0)) {
>     TranslateMessage(&msg);

This is a readability change only it seems, it should work the same 
without it.

[Alexandre Julliard]

Andrey Gusev  writes:
> @@ -634,12 +634,13 @@ static void    Control_DoInterface(CPanel* panel, HWND hWnd, HINSTANCE hInst)
>  if (!RegisterClassExW(&wc)) return;
>
> - CreateWindowExW(0, wc.lpszClassName, appName,
> -
>     WS_OVERLAPPEDWINDOW | WS_VISIBLE,
> -
>     CW_USEDEFAULT, CW_USEDEFAULT,
> -
>     CW_USEDEFAULT, CW_USEDEFAULT,
> -
>     hWnd, NULL, hInst, panel);
> - if (!panel->hWnd) return;
> - panel->hWnd = CreateWindowExW(0, wc.lpszClassName, appName,
> -
>                   WS_OVERLAPPEDWINDOW | WS_VISIBLE,
> -
>                   CW_USEDEFAULT, CW_USEDEFAULT,
> -
>                   CW_USEDEFAULT, CW_USEDEFAULT,
> -
>                   hWnd, NULL, hInst, panel);
> - if (!panel->hWnd)
> -
>    return FALSE;

You are again returning a value from a void function, please check
compiler warnings for your patches. Also note that the existing code is
correct, panel->hWnd is already set.