Re: [PATCH 5/5] includes: Fix an in/out annotation in shobjidl.idl.

[Nikolay Sivov]

On 5/15/2014 16:33, Stefan Dösinger wrote:
> include/shobjidl.idl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/shobjidl.idl b/include/shobjidl.idl
> index c9297a8..ae42c2e 100644
> --- a/include/shobjidl.idl
> +++ b/include/shobjidl.idl
> @@ -3350,7 +3350,7 @@ interface ITransferAdviseSink : IUnknown
>       HRESULT FileFailure([in] IShellItem *item,
>                           [in, unique, string] LPCWSTR itemname,
>                           [in] HRESULT hr,
> -
>                    [out, unique, size_is(crename)] LPWSTR rename,
> -
>                    [in, out, unique, size_is(crename)] LPWSTR rename,
>                     [in] ULONG crename);
> HRESULT SubStreamFailure([in] IShellItem *item,
>                          [in, string] LPCWSTR stream,

According to PSDK existing attributes are correct. Where did you find 
additional [in] ?

[PATCH 5/5] includes: Fix an in/out annotation in shobjidl.idl.

[Stefan Dösinger]

Am 15.05.2014 um 14:40 schrieb Nikolay Sivov :
> On 5/15/2014 16:33, Stefan Dösinger wrote:
> > include/shobjidl.idl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/shobjidl.idl b/include/shobjidl.idl
> > index c9297a8..ae42c2e 100644
> > --- a/include/shobjidl.idl
> > +++ b/include/shobjidl.idl
> > @@ -3350,7 +3350,7 @@ interface ITransferAdviseSink : IUnknown
> >      HRESULT FileFailure([in] IShellItem *item,
> >                          [in, unique, string] LPCWSTR itemname,
> >                          [in] HRESULT hr,
> > -
> >                    [out, unique, size_is(crename)] LPWSTR rename,
> > -
> >                    [in, out, unique, size_is(crename)] LPWSTR rename,
> >                    [in] ULONG crename);
> > HRESULT SubStreamFailure([in] IShellItem *item,
> >                             [in, string] LPCWSTR stream,
>
> According to PSDK existing attributes are correct. Where did you find additional [in] ?

It’s in the Windows 8.1 Kit. Without the in midl from Visual Studio 2013 complains. I don’t remember the exact error message.

[PATCH 5/5] includes: Fix an in/out annotation in shobjidl.idl.

[Vincent Povirk]

http://msdn.microsoft.com/en-us/library/aa367294.aspx

"The [unique] attribute cannot be applied to [out]-only top-level
pointer parameters (parameters that have only the [out] directional
attribute)."

[PATCH 5/5] includes: Fix an in/out annotation in shobjidl.idl.

[Nikolay Sivov]

On 5/15/2014 20:02, Vincent Povirk wrote:
> http://msdn.microsoft.com/en-us/library/aa367294.aspx
>
> "The [unique] attribute cannot be applied to [out]-only top-level
> pointer parameters (parameters that have only the [out] directional
> attribute)."

Interesting, I can't reproduce that  with midl 7.00.05. It's possible 
that newer versions are different which I doubt, most likely my test is 
incomplete - it only generates a header (I still expected a full syntax 
check).