On 12/30/2010 12:23 PM, Travis Athougies wrote:
Tests to ensure the HLSL compiler won't crash on malformed input.
You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style.
Adding more invalid strings because file already contains some of them isn't a valid reason for broken code.
Vitaliy.
On 12/30/10 12:48 PM, Vitaliy Margolen wrote:
On 12/30/2010 12:23 PM, Travis Athougies wrote:
Tests to ensure the HLSL compiler won't crash on malformed input.
You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style.
Adding more invalid strings because file already contains some of them isn't a valid reason for broken code.
And you keep on forgetting to number your tries. It looks like you are up to try six or seven for this, correct?
James McKenzie
-
James McKenzie -
Vitaliy Margolen