Stephan Rose wrote:
My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say "Hey, this is what we are missing/need, here are the specs, go implement". ... So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on...
I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now.
If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked. - Dan
2009/5/30 Dan Kegel dank@kegel.com:
If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked.
OH YES PLEASE.
(lots of apps missing bits of this - check over bugzilla and everything in it that's been stubbed)
- d.
On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote:
Stephan Rose wrote:
My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say "Hey, this is what we are missing/need, here are the specs, go implement". ... So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on...
I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now.
If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked.
Ok, then judging from the last few posts i'll leave DIB be for now seeing how there still seems to be some figuring out to do and I'll check into gdiplus missing bits sometime next week. :)
Thanks,
Stephan
Stephan Rose wrote:
On Sat, 2009-05-30 at 14:14 -0700, Dan Kegel wrote:
Stephan Rose wrote:
My ears perked up when the two words DIB and spec were put together in the same sentence. One frustration I encountered when wanting to contribute to wine a little over two years ago was that nobody seemed to be able to say "Hey, this is what we are missing/need, here are the specs, go implement". ... So if anyone can drop a full spec into my lap which outlines everything I need to write and where (given I adhere to things as I should of course) I won't have any issues getting that accepted later on...
I don't think such manna is likely to fall from heaven any time soon. If it was that easy to spec, we would have been done by now.
If you're looking for something better specified, try finishing off gdiplus. That's a somewhat well defined graphics package, and Wine's implementation has a few missing bits yet, last I checked.
Ok, then judging from the last few posts i'll leave DIB be for now seeing how there still seems to be some figuring out to do and I'll check into gdiplus missing bits sometime next week. :)
Thanks,
Stephan
I suppose this is as good a time as any to introduce myself.
My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed.
After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.
On Sun, May 31, 2009 at 11:16 AM, Andrew andrew@brightnightgames.com wrote:
My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed.
After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.
Welcome to Wine!
Be sure when sending patches to break them into small sets, with one change per patch. It makes it much easier to review that way, and if your patch causes a regression, much easier to identify which part if it's in multiple patches.
Austin English wrote:
On Sun, May 31, 2009 at 11:16 AM, Andrew andrew@brightnightgames.com wrote:
My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed.
After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.
Welcome to Wine!
Be sure when sending patches to break them into small sets, with one change per patch. It makes it much easier to review that way, and if your patch causes a regression, much easier to identify which part if it's in multiple patches.
Thanks for the welcome!
I am definitely doing small commits and following the WineGit wiki page. One concern I have is that the number of patches will probably be over 50 or even 75 -- I'm not sure if it'd be better to submit them all in one go as they're pretty much all alike (just stubbing), or just do batches of 5-10 every couple days as I finish them (so it's not a deluge of patches). Any suggestions?
On Sun, May 31, 2009 at 2:11 PM, Andrew Eikum andrew@brightnightgames.com wrote:
I am definitely doing small commits and following the WineGit wiki page. One concern I have is that the number of patches will probably be over 50 or even 75 -- I'm not sure if it'd be better to submit them all in one go as they're pretty much all alike (just stubbing), or just do batches of 5-10 every couple days as I finish them (so it's not a deluge of patches). Any suggestions?
No need to wait, go ahead and submit a couple. Since you're new to wine, it may take a couple days for them to get committed.
Once you've got your feet wet and a few patches submitted, go ahead and submit a few more (5-10) a day. Try to avoid flooding wine-patches. The patches don't depend on each other, and it's not a huge rush to get them all in.
And no need to wait to stub everything before sending implementations. If you've got it ready, and it works (add testcases to verify), send it in. Don't sit on your good patches, share them with everyone else :-).
On Sun, May 31, 2009 at 12:45 AM, Stephan Rose kermos@somrek.net wrote:
If you're looking for something better specified, try finishing off gdiplus.
... I'll check into gdiplus missing bits sometime next week. :)
My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed.
Excellent! (And Stephan, there's more than enough work to go around, don't worry that Andrew's going to do it all :-)
After that, I plan to begin work on implementing some of the functions. My degree's emphasis is computer graphics, so working on gdiplus will give me a chance to learn more about the field as well as apply what I already know. I'm looking forward to working with other Wine devs on gdiplus, and other parts of Wine in the future.
That's great to hear. Looking forward to seeing your patches.
BTW, don't forget to look at http://wiki.winehq.org/GdiPlus, which has a few notes that might be helpful. My archive of Lei's notes at http://kegel.com/wine/sweng/2008/project.html from last year might be useful, too - it was tailored for people new to wine who want to contribute to gdiplus. (Though its big list of bugs is mostly all fixed now, I think only four remain.) - Dan
On Sun, 2009-05-31 at 12:23 -0700, Dan Kegel wrote:
On Sun, May 31, 2009 at 12:45 AM, Stephan Rose kermos@somrek.net wrote:
If you're looking for something better specified, try finishing off gdiplus.
... I'll check into gdiplus missing bits sometime next week. :)
My name's Andrew Eikum, I'm an undergraduate Computer Science student at the University of Minnesota. I contacted a Wine dev a few weeks ago asking for a small project to use to get familiar with Wine. I was pointed towards the gdiplus section and told to begin stubbing out the missing functions, to facilitate debugging. After familiarizing myself with how Wine's DLLs are built, and with Git, I'm now making quick progress. I expect to have a (huge) patchset ready in the next week or two with most of the gdiplus functions stubbed.
Excellent! (And Stephan, there's more than enough work to go around, don't worry that Andrew's going to do it all :-)
Hahaha, not worried.
Btw, I seem to have a handle on the stringformat alignment bug. By the looks of it I may have a patch for that sometime over the next couple days. Don't know if I will make it today as I have a roughly 5'6" brunette incentive to do something other than write code tonight. :)
Stephan
-
Andrew -
Andrew Eikum
-
Austin English -
Dan Kegel -
David Gerard -
Stephan Rose