During a query I've stumbled on bug 5012 which happens to have a patch attached to it. Nine months ago it was suggested to the author to send this patch to wine-patches but either he didn't do it or it was not accepted.
Now, I don't consider myself qualified to judge the patch and I have no particular interest in it. So I may not send it to wine-patches myself.
But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches.
And it would also give a starting point for someone interested in taking an existing patch that did not get committed to then update it, clean it up, and fix it to make it acceptable.
Does that make sense?
And for reference: * Missing NOVST timezone http://bugs.winehq.org/show_bug.cgi?id=5012 (in fact the timezone data seems wrong)
On Tue, 30 Jan 2007, Francois Gouget wrote: [...]
But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches.
I see everyone agrees :-/ So could someone add the 'patch' keyword?
Since nobody else jumped on this, I went ahead and added a "patch" keyword.
On Mon, 2007-02-05 at 19:48 +0100, Francois Gouget wrote:
On Tue, 30 Jan 2007, Francois Gouget wrote: [...]
But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches.
I see everyone agrees :-/ So could someone add the 'patch' keyword?
On Thu, 8 Feb 2007, Jeremy Newman wrote:
Since nobody else jumped on this, I went ahead and added a "patch" keyword.
Argh!
So now I finally discover that after all it is possible to use the query system to get a list of the bugs that have patches. So we don't need the 'patch' keyword :-/ Sorry for all the noise.
The trick is to use the 'Advanced Querying Using Boolean Charts' at the bottom, select 'Attachment is patch', 'is equal to' and '1'. Or as a neat URL:
http://bugs.winehq.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW...
So this shows that there are 128 open bugs with patches.
So that's 128 bugs to check: * either the patch has been applied to WineHQ and then the bug should be closed (unless there are other issues, but then maybe these should go in a separate bug). * or the patch is just waiting for someone to review it, polish it up and send it to wine-patches (ok it might need a bit more than just polishing, but still, it's a start).
Francois Gouget wrote:
On Tue, 30 Jan 2007, Francois Gouget wrote: [...]
But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches.
I see everyone agrees :-/ So could someone add the 'patch' keyword?
I had added this keyword when you first asked for it... I just did not comment on it. http://bugs.winehq.org/describekeywords.cgi
--
Tony Lambregts
Tony Lambregts wrote:
Francois Gouget wrote:
On Tue, 30 Jan 2007, Francois Gouget wrote: [...]
But it would be nice if there was an easy way to find bugs that have a patch, even, and maybe especially, if it is incorrect. This would make it easier for interested parties to survey what potential fixes are languishing in Bugzilla and push them to wine-devel or wine-patches.
I see everyone agrees :-/ So could someone add the 'patch' keyword?
I had added this keyword when you first asked for it... I just did not comment on it. http://bugs.winehq.org/describekeywords.cgi
--
Tony Lambregts
Thanks. I've added the 'patch' keyword to bug 6323 (numeric keypad) patch that's been submitted but waiting for Alexandre to commit it. Fixes a known issue in World of Warcraft & Warcraft, but I would imagine fixes many other apps that use the numeric keypad ?
-
Francois Gouget -
Jeremy Newman -
Nick Law -
Tony Lambregts