Re: ws2_32: update to WSASendTo / last error patch

[James Hawkins]

On Thu, Jul 17, 2008 at 2:19 PM, Daniel Santos  wrote:
> Since this is my 1st real patch for wine, it's taken me a few iterations to
> get this down.  Attached is the updated patch to WSASendTo that includes a
> conformance test.  I have NOT run this on windows yet because I don't have
> access to a windows machine at the moment.

Then we can't accept the tests (and thus the implementation).  In the
future, please attach your test patch to a message in wine-devel
asking someone to run the test in windows.

ws2_32: update to WSASendTo / last error patch

[Roy Shea]

Howdy,
> In the future, please attach your test patch to a message in
> wine-devel asking someone to run the test in windows.

I just ran your tests.  The new tests ran without problems on my Win2K
and WinXP systems.

However I do have a few other comments.  Your formatting is not
consistent with the style of the files you edit.  Spaces around
parameters are used in dlls/ws2_32/socket.c such as:

WSASetLastError( NtStatusToWSAError( err ));

and dlls/ws2_32/tests/sock.c uses a spacing between the "if" and the
conditional such as:

if (v6 != INVALID_SOCKET)

Also, do you need to be closing the socket "s" with a call to
"closesocket"?  Be sure to do this on both regular and error paths if
it's needed.  You can look at "test_ipv6only" for an example of using
the infamous "goto out;" used throughout wine to handle cleanup when
exiting a test early.

Peace,
-Roy