Re: comctl32: Fix going to today with multiple calenders

[Nikolay Sivov]

On 9/23/2011 00:03, André Hentschel wrote:
> dlls/comctl32/monthcal.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c
> index 5f8a36c..b330871 100644
> --- a/dlls/comctl32/monthcal.c
> +++ b/dlls/comctl32/monthcal.c
> @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam)
>     if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD,
>    	     menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL))
>     {
> -
>  infoPtr->calendars[0].month = infoPtr->todaysDate;
> -
>  infoPtr->minSel = infoPtr->todaysDate;
> -
>  infoPtr->maxSel = infoPtr->todaysDate;
> -
>  MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate);
>   InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);
> }

This is wrong, it lacks notification calls and you have unneeded 
invalidate call left. Also similar case remains to be fixed.
Actually I planned to work on this tomorrow, including some other issues 
I just spotted.

comctl32: Fix going to today with multiple calenders

[André Hentschel]

Am 22.09.2011 22:17, schrieb Nikolay Sivov:
> On 9/23/2011 00:03, André Hentschel wrote:
> > dlls/comctl32/monthcal.c |    4 +---
> >   1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c
> > index 5f8a36c..b330871 100644
> > --- a/dlls/comctl32/monthcal.c
> > +++ b/dlls/comctl32/monthcal.c
> > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam)
> >     if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD,
> >                menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL))
> >     {
> > -
> >  infoPtr->calendars[0].month = infoPtr->todaysDate;
> > -
> >  infoPtr->minSel = infoPtr->todaysDate;
> > -
> >  infoPtr->maxSel = infoPtr->todaysDate;
> > -
> >  MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate);
> >   InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);
> > }
>
> This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed.
> Actually I planned to work on this tomorrow, including some other issues I just spotted.

i just thought i give multi monthcal a try and spottet that. the fix didn't broke the tests so i didn't thought about notification calls and i resent a fix for the invalidaterect right after try 1...
If you already have plans for that i'll be fine.

comctl32: Fix going to today with multiple calenders

[Nikolay Sivov]

On 9/23/2011 00:22, André Hentschel wrote:
> Am 22.09.2011 22:17, schrieb Nikolay Sivov:
> > On 9/23/2011 00:03, André Hentschel wrote:
> > > dlls/comctl32/monthcal.c |    4 +---
> > >    1 files changed, 1 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c
> > > index 5f8a36c..b330871 100644
> > > --- a/dlls/comctl32/monthcal.c
> > > +++ b/dlls/comctl32/monthcal.c
> > > @@ -1970,9 +1970,7 @@ MONTHCAL_RButtonUp(MONTHCAL_INFO *infoPtr, LPARAM lParam)
> > >      if( TrackPopupMenu(hMenu, TPM_RIGHTBUTTON | TPM_NONOTIFY | TPM_RETURNCMD,
> > >                 menupoint.x, menupoint.y, 0, infoPtr->hwndSelf, NULL))
> > >      {
> > > -
> > >  infoPtr->calendars[0].month = infoPtr->todaysDate;
> > > -
> > >  infoPtr->minSel = infoPtr->todaysDate;
> > > -
> > >  infoPtr->maxSel = infoPtr->todaysDate;
> > > -
> > >  MONTHCAL_SetCurSel(infoPtr,&infoPtr->todaysDate);
> > >    InvalidateRect(infoPtr->hwndSelf, NULL, FALSE);
> > > }
> >
> > This is wrong, it lacks notification calls and you have unneeded invalidate call left. Also similar case remains to be fixed.
> > Actually I planned to work on this tomorrow, including some other issues I just spotted.
>
> i just thought i give multi monthcal a try and spottet that. the fix didn't broke the tests so i didn't thought about notification calls and i resent a fix for the invalidaterect right after try 1...
> If you already have plans for that i'll be fine.

No, I'm all for test it as hard as possible, I just want send a bunch 
before a weekend. If you find something else please contact me.