Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

[Nikolay Sivov]

On 6/17/2012 13:11, Alexandre Goujon wrote:
> Superseeds the patch of the same name (#87003)
> Definition and assert taken from Windows Driver Kit (WDK) 8 Consumer Preview
>
> include/ddk/ntddcdvd.h |   12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/include/ddk/ntddcdvd.h b/include/ddk/ntddcdvd.h
> index 5313496..d0178c7 100644
> --- a/include/ddk/ntddcdvd.h
> +++ b/include/ddk/ntddcdvd.h
> @@ -113,7 +113,16 @@ typedef struct DVD_READ_STRUCTURE {
>       /* From 0 to 4 */
>       UCHAR LayerNumber;
>
> -}DVD_READ_STRUCTURE, * PDVD_READ_STRUCTURE;
> +} DVD_READ_STRUCTURE, *PDVD_READ_STRUCTURE;
> -
>
> +typedef struct _DVD_DESCRIPTOR_HEADER {
> - USHORT Length;
> - UCHAR Reserved[2];
>
> +#if !defined(_midl)
> - UCHAR Data[0];
>
> +#endif
> +} DVD_DESCRIPTOR_HEADER, *PDVD_DESCRIPTOR_HEADER;
> +C_ASSERT(sizeof(DVD_DESCRIPTOR_HEADER) == 4);

This looks wrong, correct name for it __midl, and this also needs a 
check for __WIDL__ probably.

[PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

[GOUJON Alexandre]

On 06/17/2012 01:16 PM, Nikolay Sivov wrote:
> This looks wrong, correct name for it __midl, and this also needs a 
> check for __WIDL__ probably.

This is exactly what's present in the header file but if you want, I can 
resubmit with
#if !(defined __midl || defined __WIDL__)