Re: [PATCH] programs/winecfg: enable CSMT checkbox on Graphics tab

[Henri Verbeet]

On 24 April 2017 at 23:01, Donat Enikeev  wrote:
> @@ -181,6 +181,9 @@ BEGIN
>      EDITTEXT    IDC_RES_DPIEDIT,188,105,23,13,ES_NUMBER|WS_TABSTOP
>      LTEXT       "#msgctxt#unit: dots/inch#dpi",IDC_STATIC,215,107,30,8
>      LTEXT       "This is a sample text using 10 point Tahoma",IDC_RES_FONT_PREVIEW,15,124,230,49
> -
> - GROUPBOX    "CSMT",IDC_STATIC,8,186,244,32
> - CONTROL     "Enable multi-threaded command stream in Direct3D",IDC_ENABLE_CSMT,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,15,202,230,8
>
> END
>
> IDD_DLLCFG DIALOG  0, 0, 260, 220

I don't think so, this is not a setting regular users should be modifying.

[PATCH] programs/winecfg: enable CSMT checkbox on Graphics tab

[Donat Enikeev]

Hi Henri,

Do you think so generally, meaning it's better to educate users in wine/regedit usage :) or the feature is not in the beta-state yet?

Its disabled by default, and even when enabled is not expected to affect non-3D apps (please correct me). And it potentially brings less harm by misconfiguration than DLL overrides available near.

Nevertheless, I think in slightly opposite way. There are number of applications that run smoothly with what you had adjusted already in this area, why not allow regular users to try an app with and without the feature in convenient way?

Best,
Donnie

25.04.2017, 00:10, "Henri Verbeet" :
> On 24 April 2017 at 23:01, Donat Enikeev  wrote:
> > @@ -181,6 +181,9 @@ BEGIN
> >       EDITTEXT IDC_RES_DPIEDIT,188,105,23,13,ES_NUMBER|WS_TABSTOP
> >       LTEXT "#msgctxt#unit: dots/inch#dpi",IDC_STATIC,215,107,30,8
> >       LTEXT "This is a sample text using 10 point Tahoma",IDC_RES_FONT_PREVIEW,15,124,230,49
> >  +
> >  + GROUPBOX "CSMT",IDC_STATIC,8,186,244,32
> >  + CONTROL "Enable multi-threaded command stream in Direct3D",IDC_ENABLE_CSMT,"Button",BS_AUTOCHECKBOX | WS_TABSTOP,15,202,230,8
> >   END
> >
> > IDD_DLLCFG DIALOG 0, 0, 260, 220
>
> I don't think so, this is not a setting regular users should be modifying.

[PATCH] programs/winecfg: enable CSMT checkbox on Graphics tab

[Henri Verbeet]

On 24 April 2017 at 23:31, Donat Enikeev  wrote:
> Do you think so generally, meaning it's better to educate users in wine/regedit usage :) or the feature is not in the beta-state yet?

It's just not something that you should ever need to modify, except
for debugging or testing purposes. I.e., at some point it will be
enabled by default, and if disabling it fixes something, that would be
a bug in Wine.
> Its disabled by default, and even when enabled is not expected to affect non-3D apps (please correct me). And it potentially brings less harm by misconfiguration than DLL overrides available near.

I don't think the case for DLL overrides in winecfg is great either, no.
> Nevertheless, I think in slightly opposite way. There are number of applications that run smoothly with what you had adjusted already in this area, why not allow regular users to try an app with and without the feature in convenient way?

At this point, enabling CSMT would be for testing and debugging
purposes. While I'd hope plenty of people will do such testing, the
idea is also that such testing would result in useful bug reports. I
don't have much hope for those if using regedit is too much of a
hurdle.

[PATCH] programs/winecfg: enable CSMT checkbox on Graphics tab

[Donat Enikeev]

Hi Henri,

Thanks, I was not aware about the plans to make CSMT enabled by default eventually (great news btw). So if it goes with the next stable release, the checkbox doesn't make sense, indeed

Best,
Donnie

25.04.2017, 00:45, "Henri Verbeet" :
> On 24 April 2017 at 23:31, Donat Enikeev  wrote:
> > Do you think so generally, meaning it's better to educate users in wine/regedit usage :) or the feature is not in the beta-state yet?
>
> It's just not something that you should ever need to modify, except
> for debugging or testing purposes. I.e., at some point it will be
> enabled by default, and if disabling it fixes something, that would be
> a bug in Wine.
> > Its disabled by default, and even when enabled is not expected to affect non-3D apps (please correct me). And it potentially brings less harm by misconfiguration than DLL overrides available near.
>
> I don't think the case for DLL overrides in winecfg is great either, no.
> > Nevertheless, I think in slightly opposite way. There are number of applications that run smoothly with what you had adjusted already in this area, why not allow regular users to try an app with and without the feature in convenient way?
>
> At this point, enabling CSMT would be for testing and debugging
> purposes. While I'd hope plenty of people will do such testing, the
> idea is also that such testing would result in useful bug reports. I
> don't have much hope for those if using regedit is too much of a
> hurdle.