Re: [PATCH 2/2] quartz/tests: Add test AVI and MPG files.

[Dmitry Timoshkov]

Zebediah Figura  wrote:
> --- a/dlls/quartz/tests/avisplitter.c
> +++ b/dlls/quartz/tests/avisplitter.c

...
> - WCHAR *filename = load_resource(avifile);

...
>  if (file == INVALID_HANDLE_VALUE)
>  {
> -
>    skip("Could not read test file \"%s\", skipping test\n", afile);
> -
>    skip("Could not read test file \"%s\", skipping test\n", wine_dbgstr_w(filename));
>    return;
> }

etc.
> --- a/dlls/quartz/tests/filtergraph.c
> +++ b/dlls/quartz/tests/filtergraph.c

...
> - WCHAR *filename = load_resource(file);

...
> -
>
> hr = IGraphBuilder_RenderFile(pgraph, filename, NULL);
> -
>
> if (hr == VFW_E_CANNOT_RENDER)
> -
>    skip("%s: codec not supported; skipping test\n", wine_dbgstr_w(file));
> -
>
> else
> -
>
> {
> -
>    ok(hr == S_OK || hr == VFW_S_AUDIO_NOT_RENDERED, "RenderFile failed: %x\n", hr);
> -
>    rungraph();
> -
>
> }
>
> releasefiltergraph();
>
> /* check reference leaks */
> - h = CreateFileW(file, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL);
> - h = CreateFileW(filename, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL);
> ok(h != INVALID_HANDLE_VALUE, "CreateFile failed: err=%d\n", GetLastError());
> CloseHandle(h);
>
> }

It seems that new tests leave the temporary created files behind.

[PATCH 2/2] quartz/tests: Add test AVI and MPG files.

[Zebediah Figura]

On 11/06/2017 09:03 PM, Dmitry Timoshkov wrote:
> It seems that new tests leave the temporary created files behind.

Whoops; you're right. Fixed that.

[PATCH 2/2] quartz/tests: Add test AVI and MPG files.

[Dmitry Timoshkov]

Zebediah Figura  wrote:
> > It seems that new tests leave the temporary created files behind.
>
> Whoops; you're right. Fixed that.

In the skipped cases it's still not fixed.