Re: [4/8] WineD3D: Support the full amount of constants in GLSL

[Henri Verbeet]

2009/4/9 Stefan Dösinger :
> Please do not apply this patch without patches 5, 6, 7 and 8. In some
> circumstances, this patch can step on the toes of inefficient MacOS drivers
> or old fglrx versions. The additional patches give wined3d knowledge of these
> driver problems to prevent this.

If this patch depends on those patches to work properly, shouldn't it
come after them?
> +void record_const_read(DWORD reg, unsigned int *array, int *num) {

This should be static. Wrt the implementation, there are only 16
boolean constants and 16 integer constants. Using a bitmap and doing a
bitcount should be trivial.