Re: [PATCH] misc/registry.c

[Andreas Mohr]

On Sun, May 19, 2002 at 09:18:42AM -0700, Dustin Navea wrote:
> ok, here is the needed patch to get Blizzard's
> installers to not complain _ever_ about not being able
> to find program start menu...  this also adds in a reg
> key for HARDWARE\DEVICEMAP\SerialComm
> "Serial0"=""COM1"
>
> I think that the code to write to HKLM may be slightly
> broken though, as I couldn't get any of the hklm
> entries in misc/registry.c to be written, except for
> the ComputerName one...  I dunno, someone wanna have a
> look at it?  I'm creating a bug for it soon as i send
> this out...

Yep, it's pretty wrong.

RTFM would definitely have helped.

winedefault.reg has had the start menu key for decades.
(http://www.winehq.com/Trouble/ also mentions it)

Thanks for the Serial0 fix, though !
(although that one probably should go to winedefault.reg, too...)

[PATCH] misc/registry.c

[Dustin Navea]

--- Andreas Mohr  wrote:
> Yep, it's pretty wrong.
>
> RTFM would definitely have helped.

actually rtfm on my part?  i did, basically thought i
copied the Computername key and replaced path to that
key with the HARDWARE\DEVICEMAP\SerialComm key's
path and then replaced the string value with Serial0
> winedefault.reg has had the start menu key for
> decades.
> (http://www.winehq.com/Trouble/ also mentions it)

True as that is, if the user doesn't use the wine
default registry i.e. install with windows, those keys
don't exist, so I added them in...
> Thanks for the Serial0 fix, though !
> (although that one probably should go to
> winedefault.reg, too...)

roger that ;)
i will have that patch tomorrow...

-Dustin

__________________________________________________
Do You Yahoo!?
LAUNCH - Your Yahoo! Music Experience
http://launch.yahoo.com

[PATCH] misc/registry.c

[Andreas Mohr]

On Sun, May 19, 2002 at 10:20:41AM -0700, Dustin Navea wrote:
> --- Andreas Mohr  wrote:
> > Yep, it's pretty wrong.
> >
> > RTFM would definitely have helped.
>
> actually rtfm on my part?  i did, basically thought i
> copied the Computername key and replaced path to that
> key with the HARDWARE\DEVICEMAP\SerialComm key's
> path and then replaced the string value with Serial0
> > winedefault.reg has had the start menu key for
> > decades.
> > (http://www.winehq.com/Trouble/ also mentions it)
>
> True as that is, if the user doesn't use the wine
> default registry i.e. install with windows, those keys
> don't exist, so I added them in...

Huh ?
These keys should *really* be there in case of a windows install,
if they aren't, then there's something very strange going on...

Also, even a windows install should really run winedefault.reg
stuff (witness Borland BDE key in winedefault.reg !).
I know, wineinstall currently doesn't seem to do this, but then I'd
say it's just not doing it right yet...

[PATCH] misc/registry.c

[Dustin Navea]

--- Andreas Mohr  wrote:
> Huh ?
> These keys should *really* be there in case of a
> windows install,
> if they aren't, then there's something very strange
> going on...

they dont get created on my computer, mandrake 8.2 and
win2k dual boot, wineinstall finds my windows
partition and says default wine registries will not be
installed...  then when i run wine, it creates them,
but only the keys that are in the source of wine...

only time the wine default registries are installed
are in the event that wineinstall cant find a windows
partition (and therefore cant find windows registries)
> Also, even a windows install should really run
> winedefault.reg
> stuff (witness Borland BDE key in winedefault.reg
> !).
> I know, wineinstall currently doesn't seem to do
> this, but then I'd
> say it's just not doing it right yet...

see above...

either way though, they are there now, no matter
what...  only reason that the keys need to be changed
is if the user decides he wants his emulated windows
directory to be something besides C:\Windows...  in
which case he would need to edit user.reg in
~/.wine...

-Dustin

__________________________________________________
Do You Yahoo!?
LAUNCH - Your Yahoo! Music Experience
http://launch.yahoo.com