cleanup w->a cross calls in crypt

[James Hawkins]

Hi,

I have checked this patch over and over, but I would appreciate it
if you guys could make sure it is ready to be committed.  I tried to
break up the changes into as many patches as I could, but these last
few functions depend on CRYPT_GetProvKeyName and CRYPT_GetTypeKeyName
which had to be unicodified as well.  The tests for these functions
will be sent in the next patch.

[James Hawkins]

oops forgot to add a changelog

Changelog
    * w->a cleanup of CryptAcquireContext, CryptEnumProviderTypes,
CryptGetDefaultProvider, and CryptSetProviderEx.

On Tue, 31 Aug 2004 21:37:50 -0400, James Hawkins  wrote:
> Hi,
> I have checked this patch over and over, but I would appreciate it
>
> if you guys could make sure it is ready to be committed.  I tried to
> break up the changes into as many patches as I could, but these last
> few functions depend on CRYPT_GetProvKeyName and CRYPT_GetTypeKeyName
> which had to be unicodified as well.  The tests for these functions
> will be sent in the next patch.
>
> --
> James Hawkins

[Alexandre Julliard]

James Hawkins  writes:
> --- include/wincrypt.h	18 Aug 2004 23:51:04 -0000	1.22
> +++ include/wincrypt.h	1 Sep 2004 01:11:45 -0000
> @@ -175,7 +175,7 @@
>      DWORD    dwProvType;
>      BYTE    *pbContextInfo;
>      DWORD    cbContextInfo;
> - LPSTR    pszProvName;
> - LPWSTR    pszProvName;
>
> } VTableProvStruc, *PVTableProvStruc;

You cannot change exported types.

[James Hawkins]

> You cannot change exported types.

I didnt think so, but is it acceptable to make a cast from w->a when
writing to this struct?  I'll write it out and send it back through.

On Thu, 02 Sep 2004 17:12:57 -0700, Alexandre Julliard
 wrote:
> James Hawkins  writes:
> > --- include/wincrypt.h        18 Aug 2004 23:51:04 -0000      1.22
> > +++ include/wincrypt.h        1 Sep 2004 01:11:45 -0000
> > @@ -175,7 +175,7 @@
> >      DWORD    dwProvType;
> >      BYTE    *pbContextInfo;
> >      DWORD    cbContextInfo;
> > - LPSTR    pszProvName;
> > - LPWSTR    pszProvName;
> >
> > } VTableProvStruc, *PVTableProvStruc;
>
> You cannot change exported types.
>
> --
> Alexandre Julliard
> [e-mail]

[Alexandre Julliard]

James Hawkins  writes:
> > You cannot change exported types.
>
> I didnt think so, but is it acceptable to make a cast from w->a when
> writing to this struct?  I'll write it out and send it back through.

No, if it's an LPSTR it has to point to an ASCII string.

[James Hawkins]

> No, if it's an LPSTR it has to point to an ASCII string.

I mean, when im assigning pszProvName is it acceptable to convert
provname from unicode to ascii and then assign provname to
pszProvName?

/* convert provname to ascii */
pProv->pVTable->pszProvName = provNameA;

On Thu, 02 Sep 2004 19:14:05 -0700, Alexandre Julliard
 wrote:
> James Hawkins  writes:
> > > You cannot change exported types.
> >
> > I didnt think so, but is it acceptable to make a cast from w->a when
> > writing to this struct?  I'll write it out and send it back through.
>
> No, if it's an LPSTR it has to point to an ASCII string.
>
> --
>
> Alexandre Julliard
> [e-mail]