Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

[Henri Verbeet]

On 11 September 2013 11:31, Stefan Dösinger  wrote:
> @@ -1880,9 +1888,8 @@ struct wined3d_device
>      WORD d3d_initialized : 1;
>      WORD inScene : 1;                   /* A flag to check for proper BeginScene / EndScene call pairs */
>      WORD softwareVertexProcessing : 1;  /* process vertex shaders using software or hardware */
> - WORD useDrawStridedSlow : 1;
> WORD filter_messages : 1;
> - WORD padding : 8;
> - WORD padding : 1;

I don't think that's quite right.

[PATCH 4/5] wined3d: Move the decoded stream info into the context.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-09-11 13:32, schrieb Henri Verbeet:> On 11 September 2013
11:31, Stefan Dösinger  wrote:
> > @@ -1880,9 +1888,8 @@ struct wined3d_device WORD d3d_initialized
> > : 1; WORD inScene : 1;                   /* A flag to check for

proper BeginScene / EndScene call pairs */
> > WORD softwareVertexProcessing : 1;  /* process vertex shaders

using software or hardware */
> > - WORD useDrawStridedSlow : 1; WORD filter_messages : 1; -
> >
> > WORD padding : 8; +    WORD padding : 1;
>
> I don't think that's quite right.

The next element is a BYTE. The 8 bits padding were stupid considering
that, it just generates a hole. Now I am removing one bit, which
leaves one bit of padding left.

I can send a separate patch that removes the 8 bits if you want, but I
didn't consider that necessary since the padding doesn't do much anyway.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIbBAEBAgAGBQJSMFYLAAoJEN0/YqbEcdMwPCEP+JBvqr+U0mPGMoapURDqm8V4
ERRVfT655e+K1G6xPZZfMAq+y+3gCrZTTqMrFx8zTvBScRMjsnbJDLi9NSSMYVNl
mO9Yszk28JYAP5MRN6qpTLkLxrX4qQkb0ZT2xQBeSSo2LCqplvZ2FmAiPlvwhm20
5inqe4j+JOuPmX5QwSMeqHj89ARgc2VZ6l56V0n7QDwTgqVOt5Zhqdge2g+GB6tp
jyxqPeINJBL8qrhom0oVjyxOI6uU/p1G2GMKdAzmCbwh7lKp8yAi8nrbscvAOYXF
ybpHDExZv7RxHMX2DuSnSVgFEULiTgjVqkKdkC+3lOPACjZTPAzgSqUY8RhAQbyc
ZHpHTYpAafovURstJPgp+2fGIWV+n4Z/PH3iy/wCai1sdESwFFvcZf6p7xc+NqEP
LSlGpuMD5YX8DDUxvR13OudqT7WqsB5mAmJJAyahLczxnztpWAMKrHmjnty8H9B2
J/WVhfbYAuqQbMClREVZ5SXDQNY3NKcp1Hpqp56GrtIAu9B6M8oGHyStB7KHvaEa
A4CNUcStrwAACpKO6SZF951C090/y7It1aaYVVklyygU50Cj3M+C0LWWj8m51t2n
nazC7AL79DY7JEjlbyrHE6Qc61ZsIKn1fTDQ92NzzxxFNuWrZIPRItSzASzvvgzf
Q94g3yVHblJMWDZ2CMI=
=7fwi
-----END PGP SIGNATURE-----

[PATCH 4/5] wined3d: Move the decoded stream info into the context.

[Henri Verbeet]

On 11 September 2013 13:37, Stefan Dösinger  wrote:
> The next element is a BYTE. The 8 bits padding were stupid considering
> that, it just generates a hole. Now I am removing one bit, which
> leaves one bit of padding left.

It doesn't really work like that, the layout is like this:

UINT (4)
WORD (2)
BYTE (1)
char (1)

Removing the 8 bits of padding is equivalent to just making the
bitfield a BYTE, and you end up with a hole after the
"surface_alignment" field.