Re: [1/2] oleaut32: add PNG loading [try2]

[Evan Stade]

On 6/19/07, Evan Stade  wrote:
> Hi,
>
> Try2: This time the rowsize is correctly aligned (on 4-byte
> boundaries) and palette-mode PNGs are allowed as well as RGB-mode
> PNGs.
>
> Changelog:
> *added support to decode some PNG files
> *added check for png.h / dynamic loading of libpng.so
>
> configure.ac               |    2
>  dlls/oleaut32/olepicture.c |  205 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 207 insertions(+), 0 deletions(-)
>
> --
> Evan Stade

Hi,

How can I improve this patch such that it will be accepted?

[1/2] oleaut32: add PNG loading [try2]

[Alexandre Julliard]

"Evan Stade"  writes:
> How can I improve this patch such that it will be accepted?

The biggest problem is that the libpng versioning scheme is broken, so
we can't find the proper soname. This will need some more configure
magic.