[PATCH 2/2 v2] msvcrt: Use GetDaylightFlag() to set dstflag value in _ftime64.

[Piotr Caban]

Signed-off-by: Piotr Caban 
---
  dlls/msvcrt/time.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

[Akihiro Sagawa]

On Fri, 21 Dec 2018 12:44:39 +0100, Piotr Caban wrote:
> Signed-off-by: Piotr Caban
>
> dlls/msvcrt/time.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Hi Piotr,
How about using is_dst function at msvcrt.c:161? From my point of view,
it's the way to set tm_isdst member in _localtime64_s function.

Akihiro Sagawa

[Piotr Caban]

Hi Akihiro,

On 12/21/18 2:19 PM, Akihiro Sagawa wrote:
> How about using is_dst function at msvcrt.c:161? From my point of view,
> it's the way to set tm_isdst member in _localtime64_s function.

is_dst function uses tzi global variable that is only updated in _tzset 
function. It will not be updated if time is adjusted while an 
application is running. I didn't check if functions that are currently 
using is_dst helper behave correctly in that case.

Thanks,
Piotr

[Akihiro Sagawa]

On Fri, 21 Dec 2018 14:48:15 +0100, Piotr Caban wrote:
> On 12/21/18 2:19 PM, Akihiro Sagawa wrote:
> > How about using is_dst function at msvcrt.c:161? From my point of view,
> > it's the way to set tm_isdst member in _localtime64_s function.
>
> is_dst function uses tzi global variable that is only updated in
> _tzset function. It will not be updated if time is adjusted while an
> application is running. I didn't check if functions that are currently
> using is_dst helper behave correctly in that case.

Thanks explanation. I got it.

Akihiro Sagawa