Re: include: flesh out d3d11.idl (try 2)

[Dmitry Timoshkov]

Austin English  wrote:
> Try 2:
> Remove L suffixes, C++ comment.
> +/* Forward declarations */

You've copied too much from the PSDK version, better leave it to someone
else, and do it step by step when particular functionality gets implemented.

include: flesh out d3d11.idl (try 2)

[Austin English]

On Thu, Jan 10, 2013 at 8:18 PM, Dmitry Timoshkov  wrote:
> Austin English  wrote:
> > Try 2:
> > Remove L suffixes, C++ comment.
> > +/* Forward declarations */
>
> You've copied too much from the PSDK version, better leave it to someone
> else, and do it step by step when particular functionality gets implemented.

The forward declarations are necessary due to the convoluted nature of
the interfaces. My end goal is to add a stub for D3D11CreateDevice,
which fixes http://bugs.winehq.org/show_bug.cgi?id=32520 (so users
don't have to disable d3d11). However, adding a stub requires
ID3D11Device and ID3D11DeviceContext, which are 158 and 413 lines
respectively. If I only add what is needed, it saves ~600 lines (1650
vs 2230), so I went ahead and added the rest.

include: flesh out d3d11.idl (try 2)

[Dmitry Timoshkov]

Austin English  wrote:
> > > +/* Forward declarations */
> >
> > You've copied too much from the PSDK version, better leave it to someone
> > else, and do it step by step when particular functionality gets implemented.
>
> The forward declarations are necessary due to the convoluted nature of
> the interfaces. My end goal is to add a stub for D3D11CreateDevice,
> which fixes http://bugs.winehq.org/show_bug.cgi?id=32520 (so users
> don't have to disable d3d11). However, adding a stub requires
> ID3D11Device and ID3D11DeviceContext, which are 158 and 413 lines
> respectively. If I only add what is needed, it saves ~600 lines (1650
> vs 2230), so I went ahead and added the rest.

I meant that you not only copied structures, declarations and definitions
without even slight attempt to make them a bit different from PSDK, but
also copied the comments. That approach clearly is not acceptable.

include: flesh out d3d11.idl (try 2)

[Austin English]

On Fri, Jan 11, 2013 at 8:42 PM, Dmitry Timoshkov  wrote:
> Austin English  wrote:
> > > > +/* Forward declarations */
> > >
> > > You've copied too much from the PSDK version, better leave it to someone
> > > else, and do it step by step when particular functionality gets implemented.
> >
> > The forward declarations are necessary due to the convoluted nature of
> > the interfaces. My end goal is to add a stub for D3D11CreateDevice,
> > which fixes http://bugs.winehq.org/show_bug.cgi?id=32520 (so users
> > don't have to disable d3d11). However, adding a stub requires
> > ID3D11Device and ID3D11DeviceContext, which are 158 and 413 lines
> > respectively. If I only add what is needed, it saves ~600 lines (1650
> > vs 2230), so I went ahead and added the rest.
>
> I meant that you not only copied structures, declarations and definitions
> without even slight attempt to make them a bit different from PSDK, but
> also copied the comments. That approach clearly is not acceptable.

Indentation was changed to match other wine headers / make it
different from the PSDK. The interface formats were also changed
(quite a bit) to match d3d10.idl.

There's only so many ways to word 'forward declarations'.

include: flesh out d3d11.idl (try 2)

[Henri Verbeet]

On 12 January 2013 03:47, Austin English  wrote:
> The forward declarations are necessary due to the convoluted nature of
> the interfaces. My end goal is to add a stub for D3D11CreateDevice,
> which fixes http://bugs.winehq.org/show_bug.cgi?id=32520 (so users
> don't have to disable d3d11). However, adding a stub requires
> ID3D11Device and ID3D11DeviceContext, which are 158 and 413 lines

If you're only adding a stub, just the forward declarations for those
are enough, actually, as long as you never dereference the pointers.
There's something to be said for doing things right the first time
though.