Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

[Vincent Cadet]

Hi peoople.

A couple of months ago, I submitted a patch I wrote to add a backlink to the previous version in WineHQ announcement page. As it has still no been applied I am sending it again here. It actually adds a few (6) lines of PHP code to the web site's template, include/plugins/announce.php .

I ahve also submitted this patch into WineHQ bugzilla ( http://bugs.winehq.org/show_bug.cgi?id=19355 ). May I ask for comments about this patch?

Thanks a lot in advance,
Vince C.

Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

[André Hentschel]

Vincent Cadet schrieb:
> Hi peoople.
>
> A couple of months ago, I submitted a patch I wrote to add a backlink to the previous version in WineHQ announcement page. As it has still no been applied I am sending it again here. It actually adds a few (6) lines of PHP code to the web site's template, include/plugins/announce.php .
>
> I ahve also submitted this patch into WineHQ bugzilla ( http://bugs.winehq.org/show_bug.cgi?id=19355 ). May I ask for comments about this patch?
>
> Thanks a lot in advance,
> Vince C.

only possible problem i spotted is, that the patch is not in "git diff" format (or git format-patch)

[Vincent Cadet]

> De: André Hentschel 
> Objet: Re: Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"
> À: "Vincent Cadet" , "Wine Devel"
> only possible problem i spotted is, that the patch is not
> in "git diff" format (or git format-patch)

?

I used diff -Nau indeed. How can I convert it into a git diff format?

Vincent

Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

[André Hentschel]

Vincent Cadet schrieb:
> > De: André Hentschel 
> > Objet: Re: Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"
> > À: "Vincent Cadet" , "Wine Devel"
> > only possible problem i spotted is, that the patch is not
> > in "git diff" format (or git format-patch)
>
> ?
>
> I used diff -Nau indeed. How can I convert it into a git diff format?
>
> Vincent

get the source of the website per git (i guess you did that?) and change the file, then do "git diff" or even better "git commit -a -m "changelog blabla" and then "git format-patch --keep-subject -o out origin"
see also the wiki page for that http://wiki.winehq.org/GitWine

Patch: bug 19355, Wine web site, link to the previous version announcement in section "changes since"

[Jeremy Newman]

It also helps if you prepend [website] to the subject. It makes it 
easier to find in a long list of wine patches.

-Newman

André Hentschel wrote:
> Vincent Cadet schrieb:
> > Hi peoople.
> >
> > A couple of months ago, I submitted a patch I wrote to add a backlink to the previous version in WineHQ announcement page. As it has still no been applied I am sending it again here. It actually adds a few (6) lines of PHP code to the web site's template, include/plugins/announce.php .
> >
> > I ahve also submitted this patch into WineHQ bugzilla ( http://bugs.winehq.org/show_bug.cgi?id=19355 ). May I ask for comments about this patch?
> >
> > Thanks a lot in advance,
> > Vince C.
>
> only possible problem i spotted is, that the patch is not in "git diff" format (or git format-patch)