Re: [PATCH] winejoystick.drv: add HID support

[Alexandre Julliard]

Aric Stewart  writes:
> Right now, only enabled if no other joystick platform layer is defined
> or HID_WINMM is explicitly defined

There shouldn't be any reason to ifdef it out, even when it's not used
it should at least be built.

[PATCH] winejoystick.drv: add HID support

[Aric Stewart]

On 2/6/17 3:14 PM, Alexandre Julliard wrote:
> Aric Stewart  writes:
> > Right now, only enabled if no other joystick platform layer is defined
> > or HID_WINMM is explicitly defined
>
> There shouldn't be any reason to ifdef it out, even when it's not used
> it should at least be built.

Hi Alexandre,

The way that driver code is done only 1 of the module can compile at a time. They all have duplicate symbols and such. So I was matching the architecture that was existing.  Do you want me to rework the architecture of the whole module to allow for multiple modules and select them more run time like dinput?  Or are you willing to reconsider the ifdef?

-aric

[PATCH] winejoystick.drv: add HID support

[Alexandre Julliard]

Aric Stewart  writes:
> Hi Alexandre,
>
> The way that driver code is done only 1 of the module can compile at a
> time. They all have duplicate symbols and such. So I was matching the
> architecture that was existing.  Do you want me to rework the
> architecture of the whole module to allow for multiple modules and
> select them more run time like dinput?  Or are you willing to
> reconsider the ifdef?

Yes, you'd have to change the architecture a little to allow multiple
modules. Otherwise, we can kill the old support and switch straight to
HID. That should be good for your regression count ;-)