RE: [PATCH 4/5] kernel32/tests: Refresh the console to clear the console font table

[Hugh McMaster]

On Tuesday, 5 Jan 2016 16:21:51 +0100, Sebastian Lackner wrote:
> On 05.01.2016 08:59, Hugh McMaster wrote:
> > The testScreenBuffer function unintentionally causes the console
> > font table to increase from 14 entries to about 40. This patch restores the font table.
> > Signed-off-by: Hugh McMaster
> >
> > dlls/kernel32/tests/console.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
>
> Signed-off-by: Sebastian Lackner
>
> (It would look better if we could restore it in the corresponding test itself, but at least I'm fine with this solution.)

I'm not sure it's possible to restore the console font table from the test, but I'll take a look.

[PATCH 4/5] kernel32/tests: Refresh the console to clear the console font table

[Sebastian Lackner]

On 06.01.2016 05:02, Hugh McMaster wrote:
> On Tuesday, 5 Jan 2016 16:21:51 +0100, Sebastian Lackner wrote:
> > On 05.01.2016 08:59, Hugh McMaster wrote:
> > > The testScreenBuffer function unintentionally causes the console
> > > font table to increase from 14 entries to about 40. This patch restores the font table.
> > > Signed-off-by: Hugh McMaster
> > >
> > > dlls/kernel32/tests/console.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> >
> > Signed-off-by: Sebastian Lackner
> >
> > (It would look better if we could restore it in the corresponding test itself, but at least I'm fine with this solution.)
>
> I'm not sure it's possible to restore the console font table from the test, but I'll take a look.

The patch already got committed, so no need to worry. If we have more tests
which influence each other, one possible solution would be to allocate a
separate console for each test.