Signed-off-by: Michael Stefaniuc mstefani@winehq.org --- dlls/msi/tests/package.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 4d384d0809..0604098ea1 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -2081,9 +2081,9 @@ static void test_condition(void) ok( r == MSICONDITION_TRUE, "wrong return val (%d)\n", r); r = MsiEvaluateConditionA(hpkg, "!nofeature="""); ok( r == MSICONDITION_TRUE, "wrong return val (%d)\n", r); - MsiEvaluateConditionA(hpkg, "$nocomponent="""); + r = MsiEvaluateConditionA(hpkg, "$nocomponent="""); ok( r == MSICONDITION_TRUE, "wrong return val (%d)\n", r); - MsiEvaluateConditionA(hpkg, "?nocomponent="""); + r = MsiEvaluateConditionA(hpkg, "?nocomponent="""); ok( r == MSICONDITION_TRUE, "wrong return val (%d)\n", r);
MsiSetPropertyA(hpkg, "A", "2");
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=55541
Your paranoid android.
=== wvistau64_fr (task log) ===
Task errors: The previous 1 run(s) terminated abnormally
=== w1064v1507 (32 bit report) ===
msi: package.c:3385: Test failed: Expected ERROR_SUCCESS, got 1618 package.c:3405: Test failed: ProductToBeRegistered = package.c:3030: Test failed: 3425: expected state 4 got 2 package.c:3030: Test failed: 3426: expected state 4 got 2 package.c:3030: Test failed: 3427: expected state 3 got 2 package.c:3030: Test failed: 3428: expected state 3 got 2 package.c:3056: Test failed: 3439: expected state 3 got 2 package.c:3056: Test failed: 3440: expected state 4 got 2 package.c:3056: Test failed: 3441: expected state 3 got 2 package.c:3056: Test failed: 3442: expected state 3 got 2 package.c:3056: Test failed: 3443: expected state 3 got 2 package.c:3056: Test failed: 3444: expected state 4 got 2 package.c:3059: Test failed: 3444: expected action -1 got 4 package.c:3056: Test failed: 3445: expected state 4 got 2 package.c:3059: Test failed: 3445: expected action -1 got 4 package.c:3056: Test failed: 3446: expected state 3 got 2 package.c:3056: Test failed: 3447: expected state 3 got 2 package.c:3467: Test failed: Expected ERROR_SUCCESS, got 1605
=== w1064v1507 (64 bit report) ===
msi: package.c:3385: Test failed: Expected ERROR_SUCCESS, got 1618 package.c:3405: Test failed: ProductToBeRegistered = package.c:3030: Test failed: 3425: expected state 4 got 2 package.c:3030: Test failed: 3426: expected state 4 got 2 package.c:3030: Test failed: 3427: expected state 3 got 2 package.c:3030: Test failed: 3428: expected state 3 got 2 package.c:3056: Test failed: 3439: expected state 3 got 2 package.c:3056: Test failed: 3440: expected state 4 got 2 package.c:3056: Test failed: 3441: expected state 3 got 2 package.c:3056: Test failed: 3442: expected state 3 got 2 package.c:3056: Test failed: 3443: expected state 3 got 2 package.c:3056: Test failed: 3444: expected state 4 got 2 package.c:3059: Test failed: 3444: expected action -1 got 4 package.c:3056: Test failed: 3445: expected state 4 got 2 package.c:3059: Test failed: 3445: expected action -1 got 4 package.c:3056: Test failed: 3446: expected state 3 got 2 package.c:3056: Test failed: 3447: expected state 3 got 2 package.c:3467: Test failed: Expected ERROR_SUCCESS, got 1618 package.c:3476: Test failed: Expected ERROR_SUCCESS, got 1618 package.c:3481: Test failed: state = -1 package.c:3030: Test failed: 3504: expected state 4 got 2 package.c:3030: Test failed: 3505: expected state 4 got 2 package.c:3030: Test failed: 3506: expected state 3 got 2 package.c:3030: Test failed: 3507: expected state 3 got 2 package.c:3030: Test failed: 3509: expected state 4 got 2 package.c:3030: Test failed: 3510: expected state 4 got 2 package.c:3030: Test failed: 3511: expected state 4 got 2 package.c:3030: Test failed: 3512: expected state 4 got 2 package.c:3030: Test failed: 3513: expected state 4 got 2 package.c:3030: Test failed: 3514: expected state 4 got 2 package.c:3030: Test failed: 3515: expected state 3 got 2 package.c:3030: Test failed: 3516: expected state 3 got 2 package.c:3056: Test failed: 3518: expected state 3 got 2 package.c:3056: Test failed: 3519: expected state 4 got 2 package.c:3056: Test failed: 3520: expected state 3 got 2 package.c:3056: Test failed: 3521: expected state 3 got 2 package.c:3056: Test failed: 3522: expected state 3 got 2 package.c:3056: Test failed: 3523: expected state 4 got 2 package.c:3056: Test failed: 3524: expected state 3 got 2 package.c:3056: Test failed: 3525: expected state 3 got 2 package.c:3056: Test failed: 3526: expected state 3 got 2 package.c:3056: Test failed: 3528: expected state 3 got 2 package.c:3056: Test failed: 3529: expected state 4 got 2 package.c:3056: Test failed: 3530: expected state 3 got 2 package.c:3056: Test failed: 3531: expected state 3 got 2 package.c:3056: Test failed: 3532: expected state 3 got 2 package.c:3056: Test failed: 3533: expected state 4 got 2 package.c:3056: Test failed: 3534: expected state 3 got 2 package.c:3056: Test failed: 3535: expected state 3 got 2 package.c:3056: Test failed: 3536: expected state 4 got 2 package.c:3059: Test failed: 3536: expected action -1 got 4 package.c:3056: Test failed: 3537: expected state 4 got 2 package.c:3059: Test failed: 3537: expected action -1 got 4 package.c:3056: Test failed: 3538: expected state 4 got 2 package.c:3059: Test failed: 3538: expected action -1 got 4 package.c:3056: Test failed: 3539: expected state 4 got 2 package.c:3056: Test failed: 3540: expected state 3 got 2 package.c:3546: Test failed: Expected ERROR_SUCCESS, got 1605
-
Hans Leidekker -
Marvin -
Michael Stefaniuc