Re: controls/scroll.c

[Dmitry Timoshkov]

"Ge van Geldorp"  wrote:
> Changelog:
>   Ge van Geldorp 
>   Remove CS_DBLCKS class style from scrollbar class since the
>   scrollbar doesn't handle double clicks anyway

You can't remove it. Scrollbar in Windows has that style, and
some applications which subclass it may depend on it.

controls/scroll.c

[Ge van Geldorp]

> From: Dmitry Timoshkov
>
> "Ge van Geldorp"  wrote:
> > Changelog:
> >   Ge van Geldorp 
> >   Remove CS_DBLCKS class style from scrollbar class since the
> >   scrollbar doesn't handle double clicks anyway
>
> You can't remove it. Scrollbar in Windows has that style, and
> some applications which subclass it may depend on it.

Ok, I guess that means that the double click messages need to be handled
then? With the current implementation you miss the second click of a
double click.

Ge van Geldorp.

controls/scroll.c

[Dmitry Timoshkov]

"Ge van Geldorp"  wrote:
> Ok, I guess that means that the double click messages need to be handled
> then?

Not necessarily. If the control does not need a particular type of message
it can just ignore it.
> With the current implementation you miss the second click of a
> double click.

What do you mean by that? Surely mouse double clicks work fine in Wine.

controls/scroll.c

[Ge van Geldorp]

> From: Dmitry Timoshkov [mailto:[e-mail]]
>
> "Ge van Geldorp"  wrote:
> > Ok, I guess that means that the double click messages need to be
> > handled then?
>
> Not necessarily. If the control does not need a particular
> type of message it can just ignore it.
> > With the current implementation you miss the second click
> > of a double click.
>
> What do you mean by that? Surely mouse double clicks work
> fine in Wine.

If you double click on the arrow of a scrollbar control the slider will
move only 1 position instead of the expected 2. This is because the
second click is delivered as a WM_LBUTTONDBLCLK (due to the CS_DBLCLKS
class style) which is not handled by the scrollbar control. I can send
you a small demo program.

Ge van Geldorp.

controls/scroll.c

[Dmitry Timoshkov]

"Ge van Geldorp"  wrote:
> If you double click on the arrow of a scrollbar control the slider will
> move only 1 position instead of the expected 2. This is because the
> second click is delivered as a WM_LBUTTONDBLCLK (due to the CS_DBLCLKS
> class style) which is not handled by the scrollbar control. I can send
> you a small demo program.

Thanks for the explanation.

There is no need for a demo. Any app with ScrollBar window class could
confirm what you mean. Spy++ under Windows clearly shows that ScrollBar
under Windows reacts on WM_LBUTTONDBLCLK the same way as on WM_LBUTTONDOWN,
and that there is only single WM_LBUTTONDOWN, followed by WM_LBUTTONUP,
WM_LBUTTONDBLCLK, WM_LBUTTONUP.

Changelog:
    Dmitry Timoshkov 
    Scrollbar should also react on WM_LBUTTONDBLCLK.