Re: Add d3drmdef.h header - try 2

[Francois Gouget]

On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:
> Changelog
>
> Add minimalistic d3drmdef.h
>
> extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR);

Two nitpicks:

Wine's headers usually don't specify extern (it's implicit).

If there's a large list of functions it can also be nice to sort them in 
alphabetical order as other forms of grouping tend to break down after a 
time. But this is not a hard and fast rules and it is not always 
followed.

Add d3drmdef.h header - try 2

[Vijay Kiran Kamuju]

Hi,

Please ignore the this one.
I am sending a new one.
I wrongly named the header file, effects of late night coding

bye,
VJ
On 3/13/07, Francois Gouget  wrote:
> On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote:
> > Changelog
> >
> > Add minimalistic d3drmdef.h
> >
> > extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR);
>
> Two nitpicks:
>
> Wine's headers usually don't specify extern (it's implicit).
>
> If there's a large list of functions it can also be nice to sort them in
> alphabetical order as other forms of grouping tend to break down after a
> time. But this is not a hard and fast rules and it is not always
> followed.
>
> --
> Francois Gouget               http://fgouget.free.fr/
>                       Computers are like airconditioners
>                 They stop working properly if you open WINDOWS