Re: [PATCH 2/2] d3drm/tests: Add more interfaces for d3drm1_QueryInterface and remove dependency on InitFunctionPtrs().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-03-17 um 18:49 schrieb Aaryaman Vasishta:
> -static BOOL InitFunctionPtrs(void)
> -{
> - d3drm_handle = LoadLibraryA("d3drm.dll");
> -
> - if(!d3drm_handle)
> - {
> -
>    skip("Could not load d3drm.dll\n");
> -
>    return FALSE;
> - }
> -
> - D3DRM_GET_PROC(Direct3DRMCreate)
> -
> - return TRUE;
>
> -}

Removing this is a good change, but it should be in a separate patch. Please do the same for vector.c, in another separate patch.
> -
>    { &IID_IDirect3DRM,               &IID_IDirect3DRM,        S_OK,                            FALSE },
> -
>    { &IID_IDirect3DRMDevice,          NULL,                   CLASS_E_CLASSNOTAVAILABLE,       FALSE },

Minor issue: Is the line misalignment here intentional?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVCJ+8AAoJEN0/YqbEcdMwBw8P/RmJiYSf0C75cddsSSYqZb2v
JdPPqOhHHt5kedsMCrV68rYzqTwKpztaFszWiffOyZgEvxMh+a6qoLM2BnfT8mxQ
PdNxftnKcsyI0RQCAYOBBBDSS9YXGCs1ohB0sLZIdX5kSgc5M6JGiziPb51rXicW
Kv2eJxaYM96YsEXDjw6ShAGCCYByQ/qHVeAmztmGF36FEgH92FzaVdFujGdEz1Px
nG4trHla0OYmVk9Q6Pppd3LA4KOBvbdYhPM5DHqNOk7FVNRGfdKi7ZjWUnP11Kc3
NXSZE2koQXpPYYtVNVKSr244mLmJjqNjXlHwPa42LQ3cwUnoqVBqCwvXaFlnu/CE
R/gsDbHoUnWoMBbHZc5MUxRS+zDXXjAsKdbPBI4sDQQI8XoXNLoGudW05VjFXb1w
qQObPWTLs62j8u8iHyJ+GpVyohaqtixX6i4P8uBjS7X+sOCyuR6bC9s4w1HPeP6A
04O3IwzE2+E6xV6sFeJj7Ibu8OCy96zJ/dKnH/iorI9kGdl5amQBvCjhROw20b8D
ApXallY+3p44RFqNis/xHvqYxVXRzqMu7ZQAjm77jXNAvC96n2iMYmgdGRLth5Of
Mxzw6NOWXnT6g9D/h6G+VtLrIWHXS/4ExaKoIIpyyqK1JNSSRLbeHQCrpLUpm4ks
sTiU6Hr+oM1c/H7+Tlg2
=x4GY
-----END PGP SIGNATURE-----