Re: [1/5] msi: Add support for 64-bit registry components.

[Alexandre Julliard]

Hans Leidekker  writes:
> dlls/msi/action.c        |   30 +++++++---
>  dlls/msi/msi_main.c      |    1 +
>  dlls/msi/msipriv.h       |    1 +
>  dlls/msi/package.c       |    2 -
>  dlls/msi/tests/install.c |  140 ++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 162 insertions(+), 12 deletions(-)

This breaks the Gecko installer on 64-bit for me.

[1/5] msi: Add support for 64-bit registry components.

[Hans Leidekker]

On Tue, 2012-06-05 at 20:35 +0200, Alexandre Julliard wrote:
> Hans Leidekker  writes:
> > dlls/msi/action.c        |   30 +++++++---
> >  dlls/msi/msi_main.c      |    1 +
> >  dlls/msi/msipriv.h       |    1 +
> >  dlls/msi/package.c       |    2 -
> >  dlls/msi/tests/install.c |  140 ++++++++++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 162 insertions(+), 12 deletions(-)
>
> This breaks the Gecko installer on 64-bit for me.

That's a bug in the installer, its registry component should be marked
as a 64-bit component.

[1/5] msi: Add support for 64-bit registry components.

[Jacek Caban]

On 6/5/12 8:48 PM, Hans Leidekker wrote:
> On Tue, 2012-06-05 at 20:35 +0200, Alexandre Julliard wrote:
> > Hans Leidekker  writes:
> > > dlls/msi/action.c        |   30 +++++++---
> > >   dlls/msi/msi_main.c      |    1 +
> > >   dlls/msi/msipriv.h       |    1 +
> > >   dlls/msi/package.c       |    2 -
> > >   dlls/msi/tests/install.c |  140 ++++++++++++++++++++++++++++++++++++++++++++++
> > >   5 files changed, 162 insertions(+), 12 deletions(-)
> >
> > This breaks the Gecko installer on 64-bit for me.
>
> That's a bug in the installer, its registry component should be marked
> as a 64-bit component.

Sounds like perfect timing to me :) Firefox 13 was released today and I 
plan to do the next Gecko update based on it in the next few days. We 
may fix Gecko installer, which will allow the patch to be committed.

Cheers,
Jacek