Re: [PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)

[Sebastian Lackner]

On 22.04.2016 15:21, Hugh McMaster wrote:
> Changes since v1: Use CONSOLE_FONT_INFO instead of undocumented CONSOLE_FONT.
> The structure is identical.
> Signed-off-by: Hugh McMaster
>
> dlls/kernel32/tests/console.c | 57 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)

You'll have to add a stub first, otherwise it breaks the tests:

$ (cd dlls/kernel32/tests/; make console.ok)
../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so console && touch console.ok
fixme:console:GetConsoleProcessList ((nil),0): stub
fixme:console:GetConsoleProcessList ((nil),1): stub
fixme:console:GetConsoleProcessList (0x118ca0,0): stub
fixme:console:GetConsoleProcessList (0x118ca0,1): stub
fixme:console:GetConsoleProcessList (0x118ca0,0): stub
fixme:console:SetConsoleFont (0x63, 0): stub!
fixme:console:SetConsoleFont (0x63, 0): stub!
wine: Call from 0x7b43b8a2 to unimplemented function KERNEL32.dll.GetConsoleFontInfo, aborting
wine: Unimplemented function KERNEL32.dll.GetConsoleFontInfo called at address 0x7b43b8a2 (thread 0009), starting debugger...

[PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)

[Hugh McMaster]

On Sunday, 24 April 2016 11:43 PM, Sebastian Lackner wrote:
> You'll have to add a stub first, otherwise it breaks the tests:

I always thought the if check was supposed to guard against such crashes.

hmod = GetModuleHandleA("kernel32.dll");
    pGetConsoleFontInfo = (void *)GetProcAddress(hmod, "GetConsoleFontInfo");
    if (!pGetConsoleFontInfo)
    {
        win_skip("GetConsoleFontInfo is not available\n");
        return;
    }

Anyway, I'm preparing a new version of the patch with additional tests,
as I've worked out the values returned by this function.

[PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)

[Sebastian Lackner]

On 25.04.2016 11:39, Hugh McMaster wrote:
> On Sunday, 24 April 2016 11:43 PM, Sebastian Lackner wrote:
> > You'll have to add a stub first, otherwise it breaks the tests:
>
> I always thought the if check was supposed to guard against such crashes.

This only works when the function name is not present in the spec file yet.
When the spec file contains "stub", code will be generated to forward the
call to __wine_spec_unimplemented_stub, so the function pointer is never
really NULL.