Re: enumerate the substorage transforms

[Dmitry Timoshkov]

"Mike McCormack"  wrote:
> --- dlls/msi/action.c 30 Sep 2005 10:32:41 -0000 1.211
> +++ dlls/msi/action.c 30 Sep 2005 11:33:20 -0000
> @@ -46,6 +46,8 @@ http://msdn.microsoft.com/library/defaul
>  #define REG_PROGRESS_VALUE 13200
>  #define COMPONENT_PROGRESS_VALUE 24000
>
> +#define LPCTSTR LPCWSTR

Do you really need this define? It looks like it's unused (not mentioning
that it breaks Wine rules on using unicode APIs).

enumerate the substorage transforms

[Mike McCormack]

Dmitry Timoshkov wrote:
> Do you really need this define? It looks like it's unused (not mentioning
> that it breaks Wine rules on using unicode APIs).

I thought that too before I sent the patch, so I removed it and 
recompiled just to make sure.  It's used by the following definition in 
include/msiquery.h:

#define MSIDBOPEN_READONLY (LPCTSTR)0

So, yes, I need it to open the database using MsiOpenDatabaseW.

Mike

enumerate the substorage transforms

[Alexandre Julliard]

Mike McCormack  writes:
> I thought that too before I sent the patch, so I removed it and 
> recompiled just to make sure.  It's used by the following definition in 
> include/msiquery.h:
>
> #define MSIDBOPEN_READONLY (LPCTSTR)0
>
> So, yes, I need it to open the database using MsiOpenDatabaseW.

It would be better to use MAKEINTRESOURCE or something along these
lines.