Re: secur32: add first SSPI test to actually see what work needs to be done

[Kai Blin]

* Kai Blin  [03/08/05, 02:03:27]:
> - sec_status = QuerySecurityPackageInfo( sec_pkg_name, &pkg_info);
> -
> - ok((long)sec_status >= 0L, "Return value of QuerySecurityPackageInfo should be >= 0, but is %ld\n", (long)sec_status);
> -

Never mind that. After running the tests on Win32, I realized I needed
to check for SEC_E_OK, not 0. I'll resubmit the patch.

Kai

secur32: add first SSPI test to actually see what work needs to be done

[Stefan Leichter]

Am Mittwoch, 3. August 2005 12:05 schrieb Kai Blin:
> - Kai Blin  [03/08/05, 02:03:27]:
> > - sec_status = QuerySecurityPackageInfo( sec_pkg_name, &pkg_info);
> > -
> > - ok((long)sec_status >= 0L, "Return value of QuerySecurityPackageInfo
> >
> > should be >= 0, but is %ld\n", (long)sec_status); +
>
> Never mind that. After running the tests on Win32, I realized I needed
> to check for SEC_E_OK, not 0. I'll resubmit the patch.
>
> Kai

Hello Kai,

you have to include your test into programs/winetest/Makefile.in too, to get 
your test into the winetest.exe, which delivers the results for 
http://test.winehq.org/data/ .

Please write the test either for QuerySecurityPackageInfoA or 
QuerySecurityPackageInfoW.

Bye Stefan

secur32: add first SSPI test to actually see what work needs to be done

[Kai Blin]

* Stefan Leichter  [03/08/05, 19:47:08]:
> you have to include your test into programs/winetest/Makefile.in too, to get 
> your test into the winetest.exe, which delivers the results for 
> http://test.winehq.org/data/ .

Whoops. Ok, sure. I'll fix that when I've fixed the patch.
> Please write the test either for QuerySecurityPackageInfoA or 
> QuerySecurityPackageInfoW.

Huh? I think the correct function will automatically be called when I
call QuerySecurityPackageInfo() with either SEC_CHAR or SEC_WCHAR.
Or is that an unusual way to test? I can change it to use the ...A and
...W functions easily.

Kai

secur32: add first SSPI test to actually see what work needs to be done

[Stefan Leichter]

Am Donnerstag, 4. August 2005 11:41 schrieb Kai Blin:
> - Stefan Leichter  [03/08/05, 19:47:08]:
> > you have to include your test into programs/winetest/Makefile.in too, to
> > get your test into the winetest.exe, which delivers the results for
> > http://test.winehq.org/data/ .
>
> Whoops. Ok, sure. I'll fix that when I've fixed the patch.
> > Please write the test either for QuerySecurityPackageInfoA or
> > QuerySecurityPackageInfoW.
>
> Huh? I think the correct function will automatically be called when I
> call QuerySecurityPackageInfo() with either SEC_CHAR or SEC_WCHAR.
> Or is that an unusual way to test? I can change it to use the ...A and
> ...W functions easily.

Well,

for my understanding functions only exported from the dll should be tested. 
The dll done not export QuerySecurityPackageInfo().

Which function (ascii or unicode) will a test like this test?

sec_status = QuerySecurityPackageInfo( NULL, NULL);

As long as this test does not crash on windows it is valid. Last error and the 
correct function result can be cheched .

Bye Stefan