On Thu, 31 Oct 2002 17:57:12 +0100, Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de wrote :
Jaco> ... Tests that will fail Jaco> with current implementation are temporarily commented outDon't comment them out, matrk them "todo". Look at the syntax in documentation/testing.
I've marked the code with a "FIXME". I don't want the test sequence to fail for this issue which is solved by my msvcrt patch. The way I've done it allows others to verify the new vfprintf patch with minimal work.
And plain inlined patches are preferred against attachments.
I'm doing this via a mail web interface, it has the ugly habit of doing line-wraps. I also prefer inline patches (like to see what is going on without have to save etc.), it is just not entirely possible for me at this point. *sigh*
Greetings, Jaco
On Thursday 31 October 2002 12:04 pm, Jaco Greeff wrote:
On Thu, 31 Oct 2002 17:57:12 +0100, Uwe Bonnes
And plain inlined patches are preferred against attachments.
Just rabble-rousing here, but, until Alexandre stops accepting them, I plan to attach all my patches. I /am/ willing to mark them as "prefer inline display" or whatever it's called, which my mailer lets me do, but personally, I prefer not even to do this unless they're very, very small (one hunk).
Since I've been doing lots of bullet-lists lately, here's a couple more:
In support of attached patches:
o Easier to separate out and organize in a filesystem o Less likely to munge international characters o No possibility to confuse carriage-returns from the e-mail with carriage-returns from the patch o Easier to view with syntax highlighting o Usually not automatically included in replies o Specifies a file-name for the patch o Doesn't /ever/ line-wrap (!) o No cut-and-paste to apply the patch o Allows us to turn on auto-line wrapping in our e-mail clients, which, in turn, makes wine-devel more readable (sometimes). o pretty icons in some clients ;)
In support of inline patches
o easier to read for some people
I say, tough cookies. Stop using elm (or yahoo) and get a real reader
:P (evil haloween laughter)
On October 31, 2002 01:46 pm, Greg Turner wrote:
In support of attached patches:
Most are irrelevant. The point is not to transport the patch to Alexandre. If so, you might as well send it directly to him. Point is to get peer review, and maybe comments. For this purpose, inlining the patch is the preferred methods, hands down. Reasons have been hashed already multiple time, please read the archives. There are good reasons why people with a lot of experience handling patches (e.g. Alexandre, Linus, etc.) prefer this method.
-
Dimitrie O. Paun -
Greg Turner -
Jaco Greeff