On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart aric@codeweavers.com wrote:
fixes bug Bug 17600
dlls/msi/table.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else.
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart aric@codeweavers.com wrote:
fixes bug Bug 17600
dlls/msi/table.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else.
Also, I'll try to look into this when I get the time, but that probably won't be until the weekend.
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart aric@codeweavers.com wrote:
fixes bug Bug 17600
dlls/msi/table.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else.
Also, I'll try to look into this when I get the time, but that probably won't be until the weekend.
And on a general note for bugzilla people: I'm not on wine-bugs anymore, so feel free to CC me on my bugs. I wasn't aware of a problem before this patch came through.
On Wed, Mar 25, 2009 at 11:15 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins truiken@gmail.com wrote:
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart aric@codeweavers.com wrote:
fixes bug Bug 17600
dlls/msi/table.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else.
Also, I'll try to look into this when I get the time, but that probably won't be until the weekend.
And on a general note for bugzilla people: I'm not on wine-bugs anymore, so feel free to CC me on my bugs. I wasn't aware of a problem before this patch came through.
Sorry folks, I had turned off all email in bugzilla and assumed that I'd still get the CCs. I've reenabled CC emails.
What appears to be happening is There is an existing table (I am unsure how many rows it has)
Then the office installer is doing an Insert on the table as TEMPORARY.
r = table_create_new_row( view, &row, temporary );
returns a row of 0
then under the temporary case we do idx -= tv->table->row_count
which is generating an idx of less than 0;
It looks like a wine bug. I can look into writing a test.
-aric
James Hawkins wrote:
On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart aric@codeweavers.com wrote:
fixes bug Bug 17600
dlls/msi/table.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Please add a test case that demonstrates what you're trying to fix. If an internal msi function is sending in a negative index, then there's a bug somewhere else.
On Wed, Mar 25, 2009 at 11:18 AM, Aric Stewart aric@codeweavers.com wrote:
What appears to be happening is There is an existing table (I am unsure how many rows it has)
Then the office installer is doing an Insert on the table as TEMPORARY.
r = table_create_new_row( view, &row, temporary );
returns a row of 0
then under the temporary case we do idx -= tv->table->row_count
which is generating an idx of less than 0;
It looks like a wine bug. I can look into writing a test.
Thanks! I appreciate it.
-
Aric Stewart -
James Hawkins