Re: [PATCH] Add Callback for wavemapper -> widOpen

[Alexandre Julliard]

"James Hatheway"  writes:
> Changelog:
>   James Hatheway - [e-mail]
>   widOpen in the wavemapper should use a callback.

It doesn't seem right to use winmm internal structures here. Are you
sure this is the right way to do it?

[PATCH] Add Callback for wavemapper -> widOpen

[James Hatheway]

> It doesn't seem right to use winmm internal structures here. Are you
> sure this is the right way to do it?

Hi Alexandre,

I implemented the callback in a very similar way as the Wave out callback
is implemented.  You can see this in the functions wodOpen(), wodOpenHelper(),
and WAVEMAP_DstCallback() , look at the data passed in the wom structure
(in dlls/winmm/wavemap/wavemap.c).  I don't see any other way that I will
be able to callback into the app when the WineOSS layer notifies the wavemap
layer.  The way it is now (wineoss directly calling the app)
causes my app to crash, and doesn't work that way on waveout.

-James

--
James Hatheway
Software Designer - Macadamian Technologies, Inc.
[e-mail] ~ http://www.macadamian.com

"Man könnte froh sein, wenn die Luft so rein wäre wie das Bier"
  "One could be happy if the air were as pure as the beer"