Re: [PATCH 3/3] d3dx9: Add D3DXCreateAnimationController tests (try 3)

[Nikolay Sivov]

On 12.01.2016 10:34, Alistair Leslie-Hughes wrote:
> +if (0) /* Windows crashes when animation is Released */
> +{
> - hr = D3DXCreateAnimationController(0, 0, 0, 0, &animation);
> - ok(hr == D3D_OK, "Got unexpected hr returned %#x.\n", hr);
> - animation->lpVtbl->Release(animation);
>
> +}

Is 'animation' NULL at this point by any chance?

[PATCH 3/3] d3dx9: Add D3DXCreateAnimationController tests (try 3)

[Alistair Leslie-Hughes]

Hi Nikolay,

On 12/01/16 19:20, Nikolay Sivov wrote:
> On 12.01.2016 10:34, Alistair Leslie-Hughes wrote:
> > +if (0) /* Windows crashes when animation is Released */
> > +{
> > - hr = D3DXCreateAnimationController(0, 0, 0, 0, &animation);
> > - ok(hr == D3D_OK, "Got unexpected hr returned %#x.\n", hr);
> > - animation->lpVtbl->Release(animation);
> >
> > +}
>
> Is 'animation' NULL at this point by any chance?

No, it returns a valid pointer and just happens to crash when it's released.

Best Regards
Alistair

[PATCH 3/3] d3dx9: Add D3DXCreateAnimationController tests (try 3)

[Matteo Bruni]

2016-01-12 9:33 GMT+01:00 Alistair Leslie-Hughes :
> Hi Nikolay,
>
> On 12/01/16 19:20, Nikolay Sivov wrote:
> > On 12.01.2016 10:34, Alistair Leslie-Hughes wrote:
> > > +if (0) /* Windows crashes when animation is Released */
> > > +{
> > > - hr = D3DXCreateAnimationController(0, 0, 0, 0, &animation);
> > > - ok(hr == D3D_OK, "Got unexpected hr returned %#x.\n", hr);
> > > - animation->lpVtbl->Release(animation);
> > >
> > > +}
> >
> > Is 'animation' NULL at this point by any chance?
>
> No, it returns a valid pointer and just happens to crash when it's released.
>
> Best Regards
> Alistair

Good catch Nikolay, it is actually NULL for me on Win7:

---
mesh.c:11119: animation 00000000.
mesh.c:11119: this is the last test seen before the exception
mesh: unhandled exception c0000005 at 0045EB8D
---

That's by commenting out the if (0) and with a trace for "animation"
just before the Release.