Re: [PATCH v3] ucrtbase: Make the strtod implementation C99 compatible

[Martin Storsjö]

On Tue, 29 Sep 2015, Martin Storsjo wrote:
> Add a test for ucrtbase that verifies these aspects of the C99
> behaviour of strtod.
> Signed-off-by: Martin Storsjo
>
> Changed the overflow checking to use base instead of 10, and added
> more test cases, as suggested by Piotr.
>
> configure.ac                    |   1 +
> dlls/msvcrt/string.c            |  68 ++++++++++++++++++----
> dlls/ucrtbase/tests/Makefile.in |   5 ++
> dlls/ucrtbase/tests/string.c    | 121 ++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 185 insertions(+), 10 deletions(-)
> create mode 100644 dlls/ucrtbase/tests/Makefile.in
> create mode 100644 dlls/ucrtbase/tests/string.c

Any further comments on this? Afaik I've addressed all comments by Piotr 
so far.

// Martin

[PATCH v3] ucrtbase: Make the strtod implementation C99 compatible

[Piotr Caban]

On 10/01/15 22:52, Martin Storsjö wrote:
> Any further comments on this? Afaik I've addressed all comments by Piotr
> so far.

The patch looks good for me.

Thanks,
Piotr