Re: ntdll: reg.c: Fix return value of NtOpenKey when key handle is NULL

[Zac Brown]

Zac Brown wrote:
> Change return value from STATUS_INVALID_PARAMETER to 
> STATUS_ACCESS_VIOLATION when retkey is null in NtOpenKey and remove 
> todo_wine from test.
>
> Tested on Windows XP, Windows 2000 and Windows 2003.
>
> -Zac Brown

Could anyone give me some feedback on this patch?

Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd chime 
in and let me know what he thought was wrong with it this time around?

Comments are greatly appreciated.

-Zac

ntdll: reg.c: Fix return value of NtOpenKey when key handle is NULL

[Alexandre Julliard]

Zac Brown  writes:
> Could anyone give me some feedback on this patch?
>
> Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd chime 
> in and let me know what he thought was wrong with it this time around?

../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so registry.c && touch registry.ok
registry.c:935: Test failed: expected ERROR_INVALID_PARAMETER, got 998
make[2]: *** [registry.ok] Error 1

ntdll: reg.c: Fix return value of NtOpenKey when key handle is NULL

[Zac Brown]

Alexandre Julliard wrote:
> Zac Brown  writes:
> > Could anyone give me some feedback on this patch?
> >
> > Talked to AJ about it pre-1.0 and he seemed to think its fine, maybe he'd chime 
> > in and let me know what he thought was wrong with it this time around?
>
> ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so registry.c && touch registry.ok
> registry.c:935: Test failed: expected ERROR_INVALID_PARAMETER, got 998
> make[2]: *** [registry.ok] Error 1

Ah ok, thanks. Out of my depth then.

-Zac