Re: [PATCH 2/6] d3d11: Use CreateDXGIFactory1 to create factory in D3D11CreateDevice.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-10-22 um 01:52 schrieb Józef Kucia:
> -
>    hr = CreateDXGIFactory(&IID_IDXGIFactory, (void **)&factory);
> -
>    hr = CreateDXGIFactory1(&IID_IDXGIFactory, (void **)&factory);

Shouldn't you request an IDXGIFactory1 interface now?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWKLJpAAoJEN0/YqbEcdMwEowQAI86raf6TRlQgfOeUiKzQTMr
2cUKnGqoaCVNwTWgFwX8WBusGAuOtak409h2VvQ3CHcvXBqAzS0XO6eXvXqZuKtn
dihGyCGtLGTOzldCsI0k50xhQj2/9+UbkCs4YAL0muFzrlpA/i1CSi+XWb9arySc
KJNjMx7wa77cbCDlWqJTrtAWK1ftHA0hWpddogxy5y16TpYq5fvBS5Nf0VkMZ28K
+EFpINsnT3ed7xJbbWgDOKxb/8K8JgkB5N2PwYn3eyDAugawIeZTU6/WG1r1nFuq
KbZnN/RZv1rB4Hqixl7Ic1sNWIB2zNQ0r0NsrHCVMLXe9Qq7cVnv2iMhYuXAs5Cj
HdBZE5nJ2V2Tncd12m7qo8vAX+Fl+caUWYIPUlHz27IYVYZ1NFmvnZKVIuqXhJu/
5xI1G5+ycYZ6+giWQY5WGm5YmPvc7ni/lcYu+KGOCk0xMFkz+9VmnZQ0N/LEHu9Y
H/ufWYUexXmFMNyZKvZbTtXttynhVY6JxuiAuW3BACIoeaygYVNumk3n6ckfh3rF
XBjoz8FbynUIf/3RUjEQukMKmwhYBJjMQvloqZMUYsptpMBYOtBww57uLZdRv8bD
jFds+0vHI99uYFYhAn9ujtiBIbn2bsb0hLJvAgKNg+qRAAj1kuwhf/4mEQKvWUJT
KKoUf43d/WBfnDH1/Sdz
=OkwT
-----END PGP SIGNATURE-----

[PATCH 2/6] d3d11: Use CreateDXGIFactory1 to create factory in D3D11CreateDevice.

[Józef Kucia]

On Thu, Oct 22, 2015 at 11:54 AM, Stefan Dösinger
 wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2015-10-22 um 01:52 schrieb Józef Kucia:
> > -
> >    hr = CreateDXGIFactory(&IID_IDXGIFactory, (void **)&factory);
> > -
> >    hr = CreateDXGIFactory1(&IID_IDXGIFactory, (void **)&factory);
>
> Shouldn't you request an IDXGIFactory1 interface now?

It doesn't really matter. CreateDXGIFactory1() accepts both
IID_IDXGIFactory and IID_IDXGIFactory1. There is no need to get
IDXGIFactory1 as we don't use any new methods introduced by DXGI 1.1.

We have tests for CreateDXGIFactory1() in test_create_factory() in dxgi/tests.