[PATCH 1/3] widl: Generate name for a tagless enum.

[Dmitry Timoshkov]

Otherwise widl crashes while generating a typelib for

typedef struct _s
{
    int type;
    union
    {
        int field;
    } u;
} s;

Signed-off-by: Dmitry Timoshkov 
---
 tools/widl/write_msft.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c
index 3a11d2ddd7..b70057eda1 100644
--- a/tools/widl/write_msft.c
+++ b/tools/widl/write_msft.c
@@ -2208,6 +2208,9 @@ static void add_union_typeinfo(msft_typelib_t *typelib, type_t *tunion)
     if (-1 < tunion->typelib_idx)
         return;

+    if (!tunion->name)
+        tunion->name = gen_name();
+
     tunion->typelib_idx = typelib->typelib_header.nrtypeinfos;
     msft_typeinfo = create_msft_typeinfo(typelib, TKIND_UNION, tunion->name, tunion->attrs);
     msft_typeinfo->typeinfo->size = 0;

[Huw Davies]

Hi Dmitry,

On Fri, Feb 14, 2020 at 08:56:12PM +0800, Dmitry Timoshkov wrote:
> widl: Generate name for a tagless enum.

I think you mean tagless *union*, right?

Huw.

[Dmitry Timoshkov]

Huw Davies  wrote:
> > widl: Generate name for a tagless enum.
>
> I think you mean tagless *union*, right?

Yes, thanks for catching this typo.

[Dmitry Timoshkov]

Huw Davies  wrote:
> On Fri, Feb 14, 2020 at 08:56:12PM +0800, Dmitry Timoshkov wrote:
> > widl: Generate name for a tagless enum.
>
> I think you mean tagless *union*, right?

Should I resend with the typo fixed, or this could be relayed to
the committer?