Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in

Alright--I'll update and resubmit when I get home from work.

The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead.  Should I be worried about that submission guideline?
------Original Message------
From: Dan Kegel
Sender: [e-mail]
To: [e-mail]
Cc: John Gilik
Subject: Re: [PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in
Sent: Mar 16, 2010 5:51 PM

Each patch in a series must compile and pass all tests,
so if you need shlwapi for patch 1, then you have
to include it in patch 1 (and then you just have one
patch, not a series).

[PATCH 2/2] cmd: Adds shlwapi library to cmd.exe's Makefile.in

[Austin English]

On Tue, Mar 16, 2010 at 7:57 PM,   wrote:
> Alright--I'll update and resubmit when I get home from work.
>
> The patch submission guidelines mentioned something about not including Makefile or Makefile.in in patches and splitting them out instead.  Should I be worried about that submission guideline?

Please bottom post.

You're probably referring to:
--------------------------
Files to include

Include a single diff of all the files you changed. You don't need to
include diffs for the following automatically generated files:

configure
include/config.h
dlls/Makefile.in
programs/Makefile.in
*/Makefile
--------------------------
programs/cmd/Makefile.in isn't in that list ;-).