wine 1.3.16: wrc compiler and LANGUAGE

[Gilles Depeyrot]

Hi,

I am testing compiling an application that uses winelib with 1.3.16 
(currently compiled with 1.2.2).

I have an issue with the resource compiler (wrc) which doesn't 
understand the LANGUAGE line. When I compile resource files, I get 
errors resembling:

file.rc:22:21: Error: syntax error

The corresponding line in the file is:

LANGUAGE LANG_FRENCH, SUBLANG_FRENCH

If I comment the line, the compilation succeeds.

Best regards,
Gilles

[Jerome Leclanche]

I don't think SUBLANG_FRENCH is valid in rc files. Have you tried
SUBLANG_NEUTRAL?

J. Leclanche

On Wed, Mar 23, 2011 at 9:54 AM, Gilles Depeyrot  wrote:
> Hi,
>
> I am testing compiling an application that uses winelib with 1.3.16
> (currently compiled with 1.2.2).
>
> I have an issue with the resource compiler (wrc) which doesn't understand
> the LANGUAGE line. When I compile resource files, I get errors resembling:
>
> file.rc:22:21: Error: syntax error
>
> The corresponding line in the file is:
>
> LANGUAGE LANG_FRENCH, SUBLANG_FRENCH
>
> If I comment the line, the compilation succeeds.
>
> Best regards,
> Gilles

[Dmitry Timoshkov]

Jerome Leclanche  wrote:
> I don't think SUBLANG_FRENCH is valid in rc files. Have you tried
> SUBLANG_NEUTRAL?

SUBLANG_FRENCH is valid, probably he is missing some include files.

[Gilles Depeyrot]

Hi,

Has there been a change between wine 1.2.2 and wine 1.3.x that would 
require adding an include file that was previously not needed?

Thanks,
Gilles

On 24/03/2011 06:29, Dmitry Timoshkov wrote:
> Jerome Leclanche  wrote:
> > I don't think SUBLANG_FRENCH is valid in rc files. Have you tried
> > SUBLANG_NEUTRAL?
>
> SUBLANG_FRENCH is valid, probably he is missing some include files.

[Dmitry Timoshkov]

[please bottom post]

Gilles Depeyrot  wrote:
> Has there been a change between wine 1.2.2 and wine 1.3.x that would 
> require adding an include file that was previously not needed?

I don't think so. Including windef.h and winuser.h should be enough.
If you could provide a small .rc file and command line you are using
that would help in figuring out the problem.

[Gilles Depeyrot]

On 24/03/2011 08:06, Dmitry Timoshkov wrote:
> Gilles Depeyrot  wrote:
> > Has there been a change between wine 1.2.2 and wine 1.3.x that would
> > require adding an include file that was previously not needed?
>
> I don't think so. Including windef.h and winuser.h should be enough.
> If you could provide a small .rc file and command line you are using
> that would help in figuring out the problem.

With the attached files and the following command line the resource file 
is compiled using wine 1.2.2 and fails using wine 1.3.16.

wrc -I$WINEHOME/include/wine/msvcrt -I$WINEHOME/include/windows 
-fofoo.res foo.rc

Best regards,
Gilles

[Austin English]

On Thu, Mar 24, 2011 at 14:25, Gilles Depeyrot  wrote:
> On 24/03/2011 08:06, Dmitry Timoshkov wrote:
> > Gilles Depeyrot  wrote:
> > > Has there been a change between wine 1.2.2 and wine 1.3.x that would
> > > require adding an include file that was previously not needed?
> >
> > I don't think so. Including windef.h and winuser.h should be enough.
> > If you could provide a small .rc file and command line you are using
> > that would help in figuring out the problem.
>
> With the attached files and the following command line the resource file is
> compiled using wine 1.2.2 and fails using wine 1.3.16.
>
> wrc -I$WINEHOME/include/wine/msvcrt -I$WINEHOME/include/windows -fofoo.res
> foo.rc

Using git bisect run ./wrc.sh:
#!/bin/bash
./configure --disable-tests || exit 125
make -j15 || exit 125
./tools/wrc/wrc -I$WINEHOME/include/wine/msvcrt
-I$WINEHOME/include/windows -fofoo.res foo.rc

revealed the bad commit to be:
e6340f1652e0328bbfeeae58462f41400b09b38a is the first bad commit
commit e6340f1652e0328bbfeeae58462f41400b09b38a
Author: Alexandre Julliard 
Date:   Wed Sep 29 20:13:28 2010 +0200

wrc: Add support for target options, and define _WIN64 for 64-bit builds.

:040000 040000 af53e5447fca71246cd4f4ec1cd91887f6c3eee2
19d82ada48a0b03253cf7a315cfd656f7c6c4be3 M      tools

though this belongs in bugzilla, not wine-devel.

[Gilles Depeyrot]

Hi,

It is valid for the Microsoft resource compiler and also for wine 1.2.2.

Gilles

On 23/03/2011 23:54, Jerome Leclanche wrote:
> I don't think SUBLANG_FRENCH is valid in rc files. Have you tried
> SUBLANG_NEUTRAL?
>
> J. Leclanche
>
> On Wed, Mar 23, 2011 at 9:54 AM, Gilles Depeyrot  wrote:
> > Hi,
> >
> > I am testing compiling an application that uses winelib with 1.3.16
> > (currently compiled with 1.2.2).
> >
> > I have an issue with the resource compiler (wrc) which doesn't understand
> > the LANGUAGE line. When I compile resource files, I get errors resembling:
> >
> > file.rc:22:21: Error: syntax error
> >
> > The corresponding line in the file is:
> >
> > LANGUAGE LANG_FRENCH, SUBLANG_FRENCH
> >
> > If I comment the line, the compilation succeeds.
> >
> > Best regards,
> > Gilles