Re: SelectionMark

[Dimitrie O. Paun]

On February 11, 2004 02:07 pm, Aric Stewart wrote:
> - if (bResult && lvItem.stateMask & LVIS_SELECTED &&
> -
>    lvItem.state&LVIS_SELECTED  && ((infoPtr->nSelectionMark
> -
>     == -1) || (lvItem.iItem <= infoPtr->nSelectionMark)))

That's some funky indentation here :)
> - {
> -
>    infoPtr->nSelectionMark = -1;
> -
>    int i = 0;
> -
>    for (i = 0; i < infoPtr->nItemCount; i++)
> -
>    {
> -
>        if (infoPtr->uCallbackMask & LVIS_SELECTED)
> -
>        {
> -
>               if (LISTVIEW_GetItemState(infoPtr, i, LVIS_SELECTED))

^^^^^^^

here as well, any particular reason?

SelectionMark

[Aric Stewart]

Ahh, doh.

I was playing with the tab space in my editor to try to get some of the 
other indentation in that file to make any sense at all without having 
to reformat large blocks of code, and then it looks like I forgot to 
change it back to my default 4 spaces value when doing modifications to 
my patch.

-aric

Dimitrie O. Paun wrote:
> On February 11, 2004 02:07 pm, Aric Stewart wrote:
> > - if (bResult && lvItem.stateMask & LVIS_SELECTED &&
> > -
> >    lvItem.state&LVIS_SELECTED  && ((infoPtr->nSelectionMark
> > -
> >     == -1) || (lvItem.iItem <= infoPtr->nSelectionMark)))
>
> That's some funky indentation here :)
> > - {
> > -
> >    infoPtr->nSelectionMark = -1;
> > -
> >    int i = 0;
> > -
> >    for (i = 0; i < infoPtr->nItemCount; i++)
> > -
> >    {
> > -
> >        if (infoPtr->uCallbackMask & LVIS_SELECTED)
> > -
> >        {
> > -
> >               if (LISTVIEW_GetItemState(infoPtr, i, LVIS_SELECTED))
>                ^^^^^^^
>
> here as well, any particular reason?

SelectionMark

[Dimitrie O. Paun]

On Thu, 12 Feb 2004, Aric Stewart wrote:
> Ahh, doh.
>
> I was playing with the tab space in my editor to try to get some of the 
> other indentation in that file to make any sense at all without having 
> to reformat large blocks of code, and then it looks like I forgot to 
> change it back to my default 4 spaces value when doing modifications to 
> my patch.

Please don't reindent that file. Infact, for that file tab should be
the standard 8 spaces, and indentation is 4. There are old blocks of
code still indented to 2 spaces, but this will change as soon as I
get a chance to get back to listview hacking.

In general, it's a real bad idea to play with the size of the tab.
Too many incompatibilities result. Tab should always be 8 spaces.
Otherwise we get problems between people's editors, when we print,
etc. We work in a very heterogenous environment, we need to stick
to standards, and for tab that is 8 spaces. Indentation is another
matter, and I think the prefered indentation for Wine is 4 spaces.
Most editors know to separate these two concepts, we should be fine
from a technical perspective.