Hi,
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ extrac32 is a console application, isn't it? Why not wmain() instead? And get rid of rather complex ParseCmdLine().
+ if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK) ExtCabCallback, 0 )) + WINE_FIXME( "Can not extract cab file:%s!!!\n", wine_dbgstr_w( pszCabFile ) ); This is an error, not a FIXME
+ if(!argv) + { + WINE_FIXME("Error!Can not get cmd line\n" ); + return 0; + } not a FIXME
+ if (argc < 2) + { + WINE_FIXME( "No options\n" ); + return 1; + } not a FIXME
+ if (fArgc != 1) + WINE_FIXME( "Invalid usage for /C flag - two filenames expected\n" ); not a FIXME
-- Kirill
extrac32 is not a console program; on Windows it doesn't create a console and doesn't write anything to stdout or stderr regardless of command line. I agree those FIXMEs you pointed out are not FIXMEs really - some of them are errors and some should be warnings. I'll fix them.
Kirill K. Smirnov wrote:
Hi,
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show ) +{ extrac32 is a console application, isn't it? Why not wmain() instead? And get rid of rather complex ParseCmdLine().
- if (!SetupIterateCabinetW( pszCabFile, 0, (PSP_FILE_CALLBACK)
ExtCabCallback, 0 ))
WINE_FIXME( "Can not extract cab file:%s!!!\n", wine_dbgstr_w(
pszCabFile ) ); This is an error, not a FIXME
- if(!argv)
- {
WINE_FIXME("Error!Can not get cmd line\n" );
return 0;
- }
not a FIXME
- if (argc < 2)
- {
WINE_FIXME( "No options\n" );
return 1;
- }
not a FIXME
if (fArgc != 1)
WINE_FIXME( "Invalid usage for /C flag - two filenames
expected\n" ); not a FIXME
-- Kirill