Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

[Bruno Jesus]

On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller  wrote:
> dlls/d3dx9_36/effect.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> - if (!This->started)
> -
>    return D3D_OK;
> -
> - This->started = FALSE;
> -
> - return D3D_OK;

Sorry to bother but why not simply force false and using a single return?

Best wishes,
Bruno

[PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

[Rico Schüller]

On 01.08.2013 15:58, Bruno Jesus wrote:
> On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller  wrote:
> > dlls/d3dx9_36/effect.c | 13 ++++++++++---
> >   1 file changed, 10 insertions(+), 3 deletions(-)
> > - if (!This->started)
> > -
> >    return D3D_OK;
> > -
> > - This->started = FALSE;
> > -
> > - return D3D_OK;
>
> Sorry to bother but why not simply force false and using a single return?
>
> Best wishes,
> Bruno

Because later it should do something useful in between (in general it 
should apply the saved states, see the next patch). The if should go 
into the next patch. Thanks for the hint, I'll send another try.

Thanks
Rico