Re: [PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.

[Alexandre Julliard]

Austin Lund  writes:
> +static void init_tbsize_results(void) {
> - tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t));
> - tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, {
> -
>    {  0,   2,  23,  24}, { 23,   2,  46,  24}, { 46,   2,  54,  24},
> -
>    { 54,   2,  77,  24}, { 77,   2, 100,  24} } };

That syntax is not portable, please avoid it.

[PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.

[Austin Lund]

On 5 November 2010 22:35, Alexandre Julliard  wrote:
> Austin Lund  writes:
> > +static void init_tbsize_results(void) {
> > - tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t));
> > - tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, {
> > - {  0,   2,  23,  24}, { 23,   2,  46,  24}, { 46,   2,  54,  24},
> > - { 54,   2,  77,  24}, { 77,   2, 100,  24} } };
>
> That syntax is not portable, please avoid it.

What C standard is desired? C89?

[PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.

[James McKenzie]

On 11/5/10 9:39 PM, Austin Lund wrote:
> On 5 November 2010 22:35, Alexandre Julliard  wrote:
> > Austin Lund  writes:
> > > +static void init_tbsize_results(void) {
> > > - tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t));
> > > - tbsize_results[0] = (tbsize_result_t) { {0, 0, 672, 26}, {100, 22}, 5, {
> > > -
> > >    {  0,   2,  23,  24}, { 23,   2,  46,  24}, { 46,   2,  54,  24},
> > > -
> > >    { 54,   2,  77,  24}, { 77,   2, 100,  24} } };
> >
> > That syntax is not portable, please avoid it.
>
> What C standard is desired? C89?

C89, yes.  C99, no.

James McKenzie