I see that the native shdocvw sets neither the Start page nor the Search page when registered. This patch forces the users home page to initially be www.winehq.com which can be confusing to IE users who are expecting the normal default of msn.com
While amusing I do not think this is correct. -aric
Jacek Caban wrote:
dlls/hlink/tests/hlink.c | 4 ---- dlls/shdocvw/shdocvw.inf | 12 +++++++++--- 2 files changed, 9 insertions(+), 7 deletions(-)
On Dec 3, 2007 11:33 PM, Aric Stewart aric@codeweavers.com wrote:
While amusing I do not think this is correct.
Plenty of OEM's change the default IE home page, and we should make it easy to do so in Wine. I think a edit box in winecfg is the best route to go with the default option being about:blank or www.winehq.org
Thanks
Do we consider wine to be an OEM or a reimplementation of the base windows? Setting the homepage is easy enough it is just a registry key. However it is not something set when registering shdocvw.dll so i dont think we should set it there. As a config option in winecfg sure.
-aric
Steven Edwards wrote:
On Dec 3, 2007 11:33 PM, Aric Stewart aric@codeweavers.com wrote:
While amusing I do not think this is correct.
Plenty of OEM's change the default IE home page, and we should make it easy to do so in Wine. I think a edit box in winecfg is the best route to go with the default option being about:blank or www.winehq.org
Thanks
On Dec 4, 2007 5:56 AM, Aric Stewart aric@codeweavers.com wrote:
Do we consider wine to be an OEM or a reimplementation of the base windows? Setting the homepage is easy enough it is just a registry key. However it is not something set when registering shdocvw.dll so i dont think we should set it there. As a config option in winecfg sure.
Distributors of Wine can be OEM's so they need the ability to change it. OEM's of course can tweak the registry before packaging. IE provides the ablity to change this setting of course for the user but the built in iexplore does not so until its further developed, I think we need the option for users to change it in winecfg. I'll try to write a patch in the next day or so that adds this functionality to winecfg.
True, making it something for wine.inf or for winecfg, but not shdocvw.dll in my opinion.
-aric
Steven Edwards wrote:
On Dec 4, 2007 5:56 AM, Aric Stewart aric@codeweavers.com wrote:
Do we consider wine to be an OEM or a reimplementation of the base windows? Setting the homepage is easy enough it is just a registry key. However it is not something set when registering shdocvw.dll so i dont think we should set it there. As a config option in winecfg sure.
Distributors of Wine can be OEM's so they need the ability to change it. OEM's of course can tweak the registry before packaging. IE provides the ablity to change this setting of course for the user but the built in iexplore does not so until its further developed, I think we need the option for users to change it in winecfg. I'll try to write a patch in the next day or so that adds this functionality to winecfg.
Aric Stewart wrote:
True, making it something for wine.inf or for winecfg, but not shdocvw.dll in my opinion.
Native shdocvw.dll doesn't support self registration at all and its registration is done by IE installer IMO. If we want to be compatible with native, we'd have to move everything from shdocvw.inf to wine.inf (and that's not the way to go IMO). I've added these registries because an app I've been working on expected default search page to be present. Also we should use it in our InternetExplorer and WebBrowser implementation. We may consider to handle these keys like we do with IE version key. That is, they may be added on iexplore.exe registration. If one wants to install native IE, he has to unregister iexplore.exe first, removing the homepage. Then IE installer will probably set its default homepage.
Jacek
Humm, maybe i am confused but (at least the win98 version of ) shdocvw.dll implements DllRegisterServer which seems to do a lot of stuff. But Setting the Start Page is not one of them. In my experience installing IE does not actually set a Start Page by default, but instead the browser seem to handle not having a Start Page by pulling up a default one.
-aric
Jacek Caban wrote:
Aric Stewart wrote:
True, making it something for wine.inf or for winecfg, but not shdocvw.dll in my opinion.
Native shdocvw.dll doesn't support self registration at all and its registration is done by IE installer IMO. If we want to be compatible with native, we'd have to move everything from shdocvw.inf to wine.inf (and that's not the way to go IMO). I've added these registries because an app I've been working on expected default search page to be present. Also we should use it in our InternetExplorer and WebBrowser implementation. We may consider to handle these keys like we do with IE version key. That is, they may be added on iexplore.exe registration. If one wants to install native IE, he has to unregister iexplore.exe first, removing the homepage. Then IE installer will probably set its default homepage.
Jacek
Aric Stewart wrote:
Humm, maybe i am confused but (at least the win98 version of ) shdocvw.dll implements DllRegisterServer which seems to do a lot of stuff. But Setting the Start Page is not one of them. In my experience installing IE does not actually set a Start Page by default, but instead the browser seem to handle not having a Start Page by pulling up a default one.
I've checked it again and it looks like shdocvw registers only its typelib, nothing else like coclasses. I will do more testing later today.
Jacek
Other side effect of the new code in shdocvw.inf is that it causes the path in Internet Explorer shortcuts to be created incorrectly and invalidly making IE unable to launch from its link file.
I would suggest all that IE registration stuff go into our iexplore.exe instead of shdocvw.dll. Either that or we move the registration of shdocvw.dll into win2000 bottles only where IE does not install anyway. But to be correct to windows i feel like none of that extra registration code should be there.
-aric
Jacek Caban wrote:
Aric Stewart wrote:
Humm, maybe i am confused but (at least the win98 version of ) shdocvw.dll implements DllRegisterServer which seems to do a lot of stuff. But Setting the Start Page is not one of them. In my experience installing IE does not actually set a Start Page by default, but instead the browser seem to handle not having a Start Page by pulling up a default one.
I've checked it again and it looks like shdocvw registers only its typelib, nothing else like coclasses. I will do more testing later today.
Jacek