Re: winetest: don't start test programs with STARTUPINFO.wShowWindow = SW_HIDE

[Francois Gouget]

On Sat, 14 Oct 2006, Mikoaj Zalewski wrote:
> It no one knowns why this option is there then maybe it's safe to remove it?

-    si.wShowWindow = SW_HIDE;
-    si.dwFlags = STARTF_USESHOWWINDOW;
+    si.dwFlags = 0;

Isn't this an attempt to make it so that running make test does not pop 
up windows that grab the focus and do things that prevent you from using 
the computer? Though some test do grab the focus and such which I guess 
means they're manually changing the state of the window..

winetest: don't start test programs with STARTUPINFO.wShowWindow = SW_HIDE

[Dmitry Timoshkov]

"Francois Gouget"  wrote:
> On Sat, 14 Oct 2006, Mikoaj Zalewski wrote:
> > It no one knowns why this option is there then maybe it's safe to remove it?
> - si.wShowWindow = SW_HIDE;
> - si.dwFlags = STARTF_USESHOWWINDOW;
> - si.dwFlags = 0;
>
> Isn't this an attempt to make it so that running make test does not pop 
> up windows that grab the focus and do things that prevent you from using 
> the computer?

The patch should be applied IMO. That SW_HIDE thing must be the cause
why user32 tests fail without a visible reason when running by winetest,
the tests must be run on a visible desktop anyway.