Re: [PATCH 4/7] comctl32/monthcal: Remove today rectangle and focus drawing code from loops

[Michael Stefaniuc]

Hello Nikolay,

On 10/05/2009 09:12 PM, Nikolay Sivov wrote:
> Fixes corrupted drawing on multiselection mode
>
> Changelog:
>      - remove today rectangle and focus drawing code from loops
>
> @@ -482,11 +485,7 @@ static BOOL MONTHCAL_SetDayFocus(MONTHCAL_INFO

*infoPtr, const SYSTEMTIME *st)
>                                 infoPtr->focusedSel.wMonth, &r);
>
> if(!st & MONTHCAL_ValidateDate(&infoPtr->focusedSel))

^^^
Is that correct or shouldn't that be a '&&'. The compiler complained 
about that and I wanted to send a patch to fix it but I see it will 
conflict with this patch.
> - {
> - static const SYSTEMTIME st_null;
> - infoPtr->focusedSel = st_null;
> - }

bye
    michael

[PATCH 4/7] comctl32/monthcal: Remove today rectangle and focus drawing code from loops

[Nikolay Sivov]

Michael Stefaniuc wrote:
> Hello Nikolay,
>
> On 10/05/2009 09:12 PM, Nikolay Sivov wrote:
> > Fixes corrupted drawing on multiselection mode
> >
> > Changelog:
> >      - remove today rectangle and focus drawing code from loops
> >
> > @@ -482,11 +485,7 @@ static BOOL MONTHCAL_SetDayFocus(MONTHCAL_INFO
>
> *infoPtr, const SYSTEMTIME *st)
> >                                 infoPtr->focusedSel.wMonth, &r);
> >
> > if(!st & MONTHCAL_ValidateDate(&infoPtr->focusedSel))
>        ^^^
>
> Is that correct or shouldn't that be a '&&'. The compiler complained 
> about that and I wanted to send a patch to fix it but I see it will 
> conflict with this patch.
> > - {
> > - static const SYSTEMTIME st_null;
> > - infoPtr->focusedSel = st_null;
> > - }
>
> bye
>     michael

Hi, Michael.

It's a typo of course, I'll sent a patch on top of last series. Thanks 
for that.