Re: Implement BiDi mirroring

[Juan Lang]

Hi Khaled,

+void doMirror(WCHAR* ch)

This should be static.

+        else if(*ch == mirrored[k].first)
+            {
+                *ch = mirrored[k].mirror;
+                return;
+            }

The else if block is indented one level too many.

Thanks,
--Juan

Implement BiDi mirroring

[Khaled Hosny]

On Wed, Jan 28, 2009 at 01:00:43PM -0800, Juan Lang wrote:
> Hi Khaled,
>
> +void doMirror(WCHAR* ch)
>
> This should be static.
> -
>    else if(*ch == mirrored[k].first)
> -
>        {
> -
>            *ch = mirrored[k].mirror;
> -
>            return;
> -
>        }
>
> The else if block is indented one level too many.

Both fixed.

Regards,
 Khaled

Implement BiDi mirroring

[Khaled Hosny]

On Wed, Jan 28, 2009 at 11:22:04PM +0200, Khaled Hosny wrote:
> On Wed, Jan 28, 2009 at 01:00:43PM -0800, Juan Lang wrote:
> > Hi Khaled,
> >
> > +void doMirror(WCHAR* ch)
> >
> > This should be static.
> > -
> >    else if(*ch == mirrored[k].first)
> > -
> >        {
> > -
> >            *ch = mirrored[k].mirror;
> > -
> >            return;
> > -
> >        }
> >
> > The else if block is indented one level too many.
>
> Both fixed.

Sorry, the patch was broken (I used git-diff --color!). I attached a new
one.

Regards,
 Khaled