Coverity and Wine (was: re: Adding Flawfinder to Patchwatcher)

[Dan Kegel]

Jason wrote:
> I'm pretty sure Coverity's tool, Prevent, costs money to buy.
> IIRC if the maintainers of an OSS project ask them to,
> they will set their http://scan.coverity.com server to
> run a scan on that project's code and upload
> the scan results to the web at no charge

And they in fact do this for Wine.  We've fixed a number
of issues it found, see e.g.
http://marc.info/?l=wine-patches&w=2&r=1&s=coverity&q=b
There are lots more to fix.

The last scan they did was in late May, though.  They
say they migrated to new servers and have been
slowly bringing up all the OSS scans again.
They haven't given a target date for having Wine's scan back online yet.
- Dan

[Paul Vriens]

Dan Kegel wrote:
> Jason wrote:
> > I'm pretty sure Coverity's tool, Prevent, costs money to buy.
> > IIRC if the maintainers of an OSS project ask them to,
> > they will set their http://scan.coverity.com server to
> > run a scan on that project's code and upload
> > the scan results to the web at no charge
>
> And they in fact do this for Wine.  We've fixed a number
> of issues it found, see e.g.
> http://marc.info/?l=wine-patches&w=2&r=1&s=coverity&q=b
> There are lots more to fix.
>
> The last scan they did was in late May, though.  They
> say they migrated to new servers and have been
> slowly bringing up all the OSS scans again.
> They haven't given a target date for having Wine's scan back online yet.
> - Dan

Or http://source.winehq.org/git/wine.git/?a=search&st=commit&s=coverity...

Drawprim.c patchwatcher failure

[Chris Ahrendt]

patching file dlls/wined3d/drawprim.c
Hunk #2 FAILED at 448.
1 out of 2 hunks FAILED -- saving rejects to file 
dlls/wined3d/drawprim.c.rej
>

Dan what does this mean on a patch I submitted tonight????
How do I fix it?

Chris

Drawprim.c patchwatcher failure

[Dmitry Timoshkov]

"Chris Ahrendt"  wrote:
> patching file dlls/wined3d/drawprim.c
> Hunk #2 FAILED at 448.
> 1 out of 2 hunks FAILED -- saving rejects to file 
> dlls/wined3d/drawprim.c.rej
> >
>
> Dan what does this mean on a patch I submitted tonight????

That means that the source you have used to generate the patch
doesn't match what patch watcher uses (latest git).
> How do I fix it?

Update to current git and regenerate the patch:

Drawprim.c patchwatcher failure

[Chris Ahrendt]

Dmitry Timoshkov wrote:
> "Chris Ahrendt"  wrote:
> > patching file dlls/wined3d/drawprim.c
> > Hunk #2 FAILED at 448.
> > 1 out of 2 hunks FAILED -- saving rejects to file 
> > dlls/wined3d/drawprim.c.rej
> > >
> >
> > Dan what does this mean on a patch I submitted tonight????
>
> That means that the source you have used to generate the patch
> doesn't match what patch watcher uses (latest git).
> > How do I fix it?
>
> Update to current git and regenerate the patch:

The thing is I just did a refresh and it said I was up to date...

I guess wait till tomorrow morning and submit it then

Chris

Drawprim.c patchwatcher failure

[Vitaliy Margolen]

Chris Ahrendt wrote:
> Dmitry Timoshkov wrote:
> > "Chris Ahrendt"  wrote:
> > > patching file dlls/wined3d/drawprim.c
> > > Hunk #2 FAILED at 448.
> > > 1 out of 2 hunks FAILED -- saving rejects to file 
> > > dlls/wined3d/drawprim.c.rej
> > > >
> > >
> > > Dan what does this mean on a patch I submitted tonight????
> >
> > That means that the source you have used to generate the patch
> > doesn't match what patch watcher uses (latest git).
> > > How do I fix it?
> >
> > Update to current git and regenerate the patch:
>
> The thing is I just did a refresh and it said I was up to date...
>
> I guess wait till tomorrow morning and submit it then

The proper way to do it is:
git fetch
git rebase origin

For more information on how to use git see http://wiki.winehq.org/GitWine
and of course git's manual.

Vitaliy.

Drawprim.c patchwatcher failure

[Chris Ahrendt]

Vitaliy Margolen wrote:
> Chris Ahrendt wrote:
> > Dmitry Timoshkov wrote:
> > > "Chris Ahrendt"  wrote:
> > > > patching file dlls/wined3d/drawprim.c
> > > > Hunk #2 FAILED at 448.
> > > > 1 out of 2 hunks FAILED -- saving rejects to file 
> > > > dlls/wined3d/drawprim.c.rej
> > > >
> > > > Dan what does this mean on a patch I submitted tonight????
> > >
> > > That means that the source you have used to generate the patch
> > > doesn't match what patch watcher uses (latest git).
> > > > How do I fix it?
> > >
> > > Update to current git and regenerate the patch:
> >
> > The thing is I just did a refresh and it said I was up to date...
> >
> > I guess wait till tomorrow morning and submit it then
>
> The proper way to do it is:
> git fetch
> git rebase origin
>
> For more information on how to use git see http://wiki.winehq.org/GitWine
> and of course git's manual.
>
> Vitaliy.

Did that before I submitted it..

chris

Drawprim.c patchwatcher failure

[Michael Stefaniuc]

Vitaliy Margolen wrote:
> Chris Ahrendt wrote:
> > Dmitry Timoshkov wrote:
> > > "Chris Ahrendt"  wrote:
> > > > How do I fix it?
> > >
> > > Update to current git and regenerate the patch:
> >
> > The thing is I just did a refresh and it said I was up to date...
> >
> > I guess wait till tomorrow morning and submit it then
>
> The proper way to do it is:
> git fetch
> git rebase origin

Or in one line
git pull --rebase
If that's your normal operation mode than configuring your branch
(assuming the "master" branch here) correctly will save typing work:
git config branch.master.remote origin
git config branch.master.merge refs/heads/master
git config branch.master.rebase true
After that "git pull" will be enough to do the right thing.
> For more information on how to use git see http://wiki.winehq.org/GitWine

Ugh! That page is in serious need of a cleanup as it didn't keep up with
the UI advances of git. E.g. "3.5. Editing commits" can be shortened to
"git commit --ammend" and "git rebase -i".
I'll look if I find some time over the weekend to go over it and fix it.
> and of course git's manual.

bye
    michael