Joerg-Cyril.Hoehle@t-systems.com writes:
Hi,
[unmodified & sent alone. There's no apply failure in testbot.]
With this patch, MacOS will be the first to correctly implement the allowed ordering of Get and ReleaseBuffer according to my rendering tests (see bug #27937).
[...capture mode]
I believe that ReleaseBuffer(0) always returns S_OK, like in the render case.
Verified indeed. But I've not finalized capture code yet (I'm not familiar with capture, so it takes more time).
Because my patch changes the type of getbuf_last, I had to slightly modify AudioCaptureClient already: @@ -1781,7 +1797,7 @@ static HRESULT WINAPI AudioCaptureClient_GetBuffer(IAudioCaptureClient *iface, *flags = 0; This->written_frames += *frames; This->inbuf_frames -= *frames;
- This->getbuf_last = TRUE;
- This->getbuf_last = 1;
This fake patch fragment in the message confuses git apply. Please don't do that.